azure-powershell
azure-powershell copied to clipboard
Fix bug where parameters could not be toggled off
Description
Some parameters for the Publish-AzWebApp cmdlet need to be able to be set to false. The current parameters are of type SwitchParameters so they can only be set to true. This change will change some parameters to the type nullable boolean. This is a bug fix.
Mandatory Checklist
-
Please choose the target release of Azure PowerShell
- [X] General release
- [ ] Public preview
- [ ] Private preview
- [ ] Engineering build
- [ ] N/A
-
[X] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:
-
SHOULD update
ChangeLog.md
file(s) appropriately- For SDK-based development mode, update
src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.- A snippet outlining the change(s) made in the PR should be written under the
## Upcoming Release
header in the past tense.
- A snippet outlining the change(s) made in the PR should be written under the
- For autorest-based development mode, include the changelog in the PR description.
- Should not change
ChangeLog.md
if no new release is required, such as fixing test case only.
- For SDK-based development mode, update
- SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
- SHOULD have proper test coverage for changes in pull request.
- SHOULD NOT adjust version of module manually in pull request
️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Breaking Change Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation ❌ Publish-AzWebApp The cmdlet 'Publish-AzWebApp' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'Clean'. Change the type for parameter 'Clean' back to 'System.Management.Automation.SwitchParameter'. ❌ Publish-AzWebApp The cmdlet 'Publish-AzWebApp' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'Async'. Change the type for parameter 'Async' back to 'System.Management.Automation.SwitchParameter'. ❌ Publish-AzWebApp The cmdlet 'Publish-AzWebApp' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'Restart'. Change the type for parameter 'Restart' back to 'System.Management.Automation.SwitchParameter'. ❌Windows PowerShell - Windows
Type Cmdlet Description Remediation ❌ Publish-AzWebApp The cmdlet 'Publish-AzWebApp' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'Clean'. Change the type for parameter 'Clean' back to 'System.Management.Automation.SwitchParameter'. ❌ Publish-AzWebApp The cmdlet 'Publish-AzWebApp' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'Async'. Change the type for parameter 'Async' back to 'System.Management.Automation.SwitchParameter'. ❌ Publish-AzWebApp The cmdlet 'Publish-AzWebApp' no longer supports the type 'System.Management.Automation.SwitchParameter' for parameter 'Restart'. Change the type for parameter 'Restart' back to 'System.Management.Automation.SwitchParameter'. ️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
To the author of the pull request, This PR was labeled "Breaking Change Release" because it contains breaking changes.
Hi @dannysongg, this PR introduce breaking changes which were not pre-announced in the former 2 releases. Please take the 2 PRs for example: Add upcoming Breaking Change message and the breaking change update.
First, you have add the upcoming breaking change message in Az 12.1.0 (2024-07-02). Second, you can submit this PR in Az 13.0.0.
‼️ DO NOT MERGE THIS PR ‼️ This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.
@YanaXu this is a bug fix that fixes a CRI. Cx needs change released ASAP
Hi @dannysongg, please confirm this: it's a bug fix, which means the cmdlet is not working before. Is this correct? If yes, please suppress the breaking chagnes. If no, it's a breaking change and we need to hold it.
/azp run
Hi @dannysongg, please confirm this: it's a bug fix, which means the cmdlet is not working before. Is this correct? If yes, please suppress the breaking chagnes. If no, it's a breaking change and we need to hold it.
Hi @dannysongg, please confirm this comment. FYI, the code freeze date is next Monday.
@YanaXu yes this is a bug fix. This is fixing an unintended behavior reported by Cx. I will suppress the breaking change.