azure-powershell [Az.Network] Added a new command 'New-AzNetworkWatcherMigrateClassicConnectionMonitor' for Network watcher Connection monitor

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell
- [x] General release
- [ ] Public preview
- [ ] Private preview
- [ ] Engineering build
- [ ] N/A
[x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

Jan 25 '24 18:01 v-sapanchal

️✔️Az.Accounts

️✔️Az.ApplicationInsights

️✔️Az.Batch

️✔️Az.CognitiveServices

️✔️Az.Compute

️✔️Az.ContainerRegistry

️✔️Az.CosmosDB

️✔️Az.DataLakeStore

️✔️Az.Dns

️✔️Az.EventHub

⚠️Az.KeyVault

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	22.09 %	Test coverage for the module cannot be lower than 50%.

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	22.09%	Test coverage for the module cannot be lower than 50%.

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	22.09%	Test coverage for the module cannot be lower than 50%.

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	22.09%	Test coverage for the module cannot be lower than 50%.

️✔️Az.ManagedServiceIdentity

⚠️Az.Monitor

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	18.02 %	Test coverage for the module cannot be lower than 50%.

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	18.02%	Test coverage for the module cannot be lower than 50%.

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	18.02%	Test coverage for the module cannot be lower than 50%.

Type	Title	Current Coverage	Description
⚠️	Test Coverage Less Than 50%	18.02%	Test coverage for the module cannot be lower than 50%.

️✔️Az.NetAppFiles

️✔️Az.Network

️✔️Az.OperationalInsights

️✔️Az.PrivateDns

️✔️Az.RecoveryServices

️✔️Az.Resources

️✔️Az.Security

️✔️Az.ServiceBus

️✔️Az.SignalR

️✔️Az.Sql

️✔️Az.Storage

️✔️Az.Websites

Jan 25 '24 18:01 azure-client-tools-bot-prd[bot]

"Assembly","HelpFile","Target","Severity","ProblemId","Description","Remediation"
"Az.Network","","Migrate-AzNetworkWatcherClassicConnectionMonitor","1","6050","Help missing for cmdlet Migrate-AzNetworkWatcherClassicConnectionMonitor implemented by class Microsoft.Azure.Commands.Network.NetworkWatcher.ConnectionMonitor.MigrateNetworkWatcherClassicConnectionMonitor","Add Help record for cmdlet Migrate-AzNetworkWatcherClassicConnectionMonitor to help file."

"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Network","Microsoft.Azure.Commands.Network.NetworkWatcher.ConnectionMonitor.MigrateNetworkWatcherClassicConnectionMonitor","Migrate-AzNetworkWatcherClassicConnectionMonitor","1","8300","Migrate-AzNetworkWatcherClassicConnectionMonitor uses the verb 'Migrate', which is not on the list of approved verbs for PowerShell commands. Use the cmdlet 'Get-Verb' to see the full list of approved verbs and consider renaming the cmdlet.","Consider renaming the cmdlet to use an approved verb for PowerShell."

Feb 18 '24 04:02 msJinLei

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Feb 18 '24 05:02 github-actions[bot]

Modified the command verb as mentioned in the verb list.

Feb 29 '24 07:02 v-sapanchal

The new cmdlet name New-AzNetworkWatcherMigrateClassicConnectionMonitor does not clearly show your intent. Will the backend create a new version of the connection monitor to convert the existing one to V2? If the latter, then what do you think renaming the cmdlet to Convert-AzNetworkWatcherClassicConnectionMonitor?

Mar 05 '24 08:03 vidai-msft

@v-sapanchal Please also check the following action items.

Use platyPS to generate the help doc of the new cmdlet https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md
Add new test case for this cmdlet
Update ChangeLog.md

Mar 05 '24 08:03 vidai-msft

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Mar 05 '24 08:03 github-actions[bot]

Yes, this is the intent, we are updating existing connection monitor by converting to V2 version. and I have updated the name as you suggested, thank you for that.

Mar 07 '24 17:03 v-sapanchal

@v-sapanchal Can you please finish the below action items?

Update ChangeLog.md to describe your changes. Please add the new entry as the first entry under the Upcoming Release section.
I noticed you have added a new test case. Please upload the recorded .json file as well. That is the reason why the test step failed on CI.

Please kindly note the cut off date of development for this sprint is by EOD next Monday.

Mar 22 '24 04:03 vidai-msft

Updated the change log for this new command.
Getting some access issue while running the test cases, posted the same on channel as well, working on it.

Mar 22 '24 10:03 v-sapanchal

Hi @vidai-msft , for this point "I noticed you have added a new test case. Please upload the recorded .json file as well. That is the reason why the test step failed on CI" we have added the test cases recorded json file.

Apr 10 '24 10:04 v-sapanchal

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Apr 11 '24 07:04 github-actions[bot]

/azp run

Apr 12 '24 00:04 Nickcandy

Azure Pipelines successfully started running 3 pipeline(s).

Apr 12 '24 00:04 azure-pipelines[bot]

azure-powershell azure-powershell copied to clipboard

[Az.Network] Added a new command 'New-AzNetworkWatcherMigrateClassicConnectionMonitor' for Network watcher Connection monitor

Description

Mandatory Checklist

azure-powershell
azure-powershell copied to clipboard