azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Generated cmdlets for new API Revoke Token as part of new API preview…

Open RamyaElangovanP opened this issue 1 year ago • 4 comments

… version 2023-07-31-preview

Description

Mandatory Checklist

  • Please choose the target release of Azure PowerShell

    • [ ] General release
    • [ ] Public preview
    • [x] Private preview
    • [ ] Engineering build
    • [ ] N/A
  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

RamyaElangovanP avatar Dec 06 '23 08:12 RamyaElangovanP

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
❌Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
❌Breaking Change Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation
Update-AzFederatedIdentityCredential The parameter set '__AllParameterSets' for cmdlet 'Update-AzFederatedIdentityCredential' has been removed. Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzFederatedIdentityCredential'.
Update-AzUserAssignedIdentity The parameter set '__AllParameterSets' for cmdlet 'Update-AzUserAssignedIdentity' has been removed. Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzUserAssignedIdentity'.
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzFederatedIdentityCredential Get-AzFederatedIdentityCredential Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzFederatedIdentityCredential Get-AzFederatedIdentityCredential changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzSystemAssignedIdentity Get-AzSystemAssignedIdentity Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzSystemAssignedIdentity Get-AzSystemAssignedIdentity changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzUserAssignedIdentity Get-AzUserAssignedIdentity Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzUserAssignedIdentity Get-AzUserAssignedIdentity changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
❌Help Example Check
❌PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
Get-AzUserAssignedIdentityAssociatedResource 1 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add title for the example. Remove any placeholders.
Get-AzUserAssignedIdentityAssociatedResource 1 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add code for the example. Remove any placeholders.
Get-AzUserAssignedIdentityAssociatedResource 1 0 MissingExampleOutput Output of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add output for the example. Remove any placeholders.
Get-AzUserAssignedIdentityAssociatedResource 1 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add description for the example. Remove any placeholders.
Get-AzUserAssignedIdentityAssociatedResource 2 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add title for the example. Remove any placeholders.
Get-AzUserAssignedIdentityAssociatedResource 2 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add code for the example. Remove any placeholders.
Get-AzUserAssignedIdentityAssociatedResource 2 0 MissingExampleOutput Output of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add output for the example. Remove any placeholders.
Get-AzUserAssignedIdentityAssociatedResource 2 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Get-AzUserAssignedIdentityAssociatedResource.md Add description for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 1 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add title for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 1 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add code for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 1 0 MissingExampleOutput Output of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add output for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 1 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add description for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 2 0 MissingExampleTitle Title of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add title for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 2 0 MissingExampleCode Code of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add code for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 2 0 MissingExampleOutput Output of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add output for the example. Remove any placeholders.
Revoke-AzUserAssignedIdentityToken 2 0 MissingExampleDescription Description of the example is missing. D:\a_work\1\s\src\ManagedServiceIdentity\ManagedServiceIdentity.Autorest\docs\Revoke-AzUserAssignedIdentityToken.md Add description for the example. Remove any placeholders.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ManagedServiceIdentity. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
❌Test
❌PowerShell Core - Linux
❌PowerShell Core - MacOS
❌PowerShell Core - Windows

@RamyaElangovanP Would you please fix the test failures?

dolauli avatar Dec 07 '23 01:12 dolauli

@RamyaElangovanP Is this PR still valid? If no update, we will close it after a week.

dolauli avatar Dec 19 '23 01:12 dolauli

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

github-actions[bot] avatar Jan 29 '24 02:01 github-actions[bot]