azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Add a github workflow to enforce reviews

Open Sandido opened this issue 1 year ago • 4 comments

Description

Branched from https://github.com/Azure/azure-powershell/pull/23033

Checklist

  • [ ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Sandido avatar Oct 20 '23 18:10 Sandido

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

‼️ DO NOT MERGE THIS PR ‼️ This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

github-actions[bot] avatar Oct 20 '23 18:10 github-actions[bot]

Hi @Sandido , One comment is from my team: don't use an additional config file. That means only use .github/CODEOWNERS but don't add .github/enforce_review_paths.txt. To make it work, we have to config .github/CODEOWNERS like below and let .github/workflows/script/enforce_required_reviewers_check.ps1 to handle the line # enforce=true. Please update it accordingly and test it.

# To make sure Network PRs go to the right branch, e.g. network-april
/src/Network/    @Joanna-Yang-Art @htippanaboya

# enforce=true
/src/Compute/Compute	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.AlcWrapper	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.Autorest	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.Helpers	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/Compute.Management.Sdk	@bilaakpan-ms @sandido @haagha @grizzlytheodore
# enforce=true
/src/Compute/documentation	@bilaakpan-ms @sandido @haagha @grizzlytheodore

/src/Compute/    @bilaakpan-ms @sandido @haagha @grizzlytheodore

/src/PolicyInsights/  @pilor
/src/Batch/ @wiboris @dpwatrous

# Make sure changes to .github folder go through our team's double check
/.github/        @isra-fel

YanaXu avatar Oct 30 '23 07:10 YanaXu

@YanaXu

wyunchi-ms avatar Jan 30 '24 07:01 wyunchi-ms

Hi @YanaXu @Sandido Please help confirm whether this PR is active or not. If not needed, or will not be needed currenly please close it. Thanks!

NoriZC avatar May 29 '24 11:05 NoriZC