azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Configured `-SecurityType` , `-Vtpm` and `-SecureBoot` for `New-AzVm`…

Open pselugar opened this issue 2 years ago • 1 comments

…, New-AzVmss,Update-AzVm, Update-AzVmss

  • Added Trusted Launch logic to New-AzVm, New-AzVmss, Update-AzVm, Update-AzVmss cmdlets.
  • Configured -SecurityType, -EnableVtpm, -EnableSecureBoot optional parameters for above mentioned cmdlets.
  • Link to PR Design for ref : https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1232
  • Extended same logic for New-AzVmConfig and New-AzVmssConfig cmdlets.

Checklist

  • [ ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

pselugar avatar Sep 15 '22 18:09 pselugar

its missing config cmdlets. I say thoroughly test using debug mode for all of this and also create an end-to-end test

grizzlytheodore avatar Sep 15 '22 18:09 grizzlytheodore

Adding Do Not Merge label while we review.

Sandido avatar Oct 06 '22 18:10 Sandido

/azp run

Sandido avatar Nov 01 '22 16:11 Sandido

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Nov 01 '22 16:11 azure-pipelines[bot]

This test is failing, please verify it fails in Playback mode locally and re-record it: Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests.TestVirtualMachineScaleSetReimageUpdate [FAIL] 2022-11-07T20:05:28.8355706Z X Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests.TestVirtualMachineScaleSetReimageUpdate [1s 78ms] 2022-11-07T20:05:28.8779376Z EXEC : error Message: [D:\a\1\s\build.proj] 2022-11-07T20:05:28.8812934Z System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Unable to find a matching HTTP request for URL 'GET /subscriptions/e37510d7-33b6-4676-886f-ee75bcc01871/providers/Microsoft.Compute/locations/eastus/publishers?'. Calling method Item().

Sandido avatar Nov 08 '22 13:11 Sandido

@pselugar another test is fialing. Verify it fails locally in playback mode and re-record it: Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests.TestVirtualMachineScaleSetSecurityTypeWithoutConfig [FAIL] 2022-11-07T20:05:48.7333976Z X Microsoft.Azure.Commands.Compute.Test.ScenarioTests.VirtualMachineScaleSetTests.TestVirtualMachineScaleSetSecurityTypeWithoutConfig [1s 232ms] 2022-11-07T20:05:48.7339555Z EXEC : error Message: [D:\a\1\s\build.proj] 2022-11-07T20:05:48.7342799Z System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Unable to find a matching HTTP request for URL 'GET /subscriptions/e37510d7-33b6-4676-886f-ee75bcc01871/resourceGroups/vmss1crptestps9480/providers/Microsoft.Compute/virtualMachineScaleSets/vmss1crptestps9480?'.

Sandido avatar Nov 08 '22 13:11 Sandido

/azp run azure-powershell - powershell-core

msJinLei avatar Dec 16 '22 00:12 msJinLei

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Dec 16 '22 00:12 azure-pipelines[bot]