azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

[EventHubs]: Removing manual cmdlets that would be migrated.

Open damodaravadhani opened this issue 2 years ago • 2 comments

Description

Checklist

  • [ ] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

damodaravadhani avatar Sep 13 '22 15:09 damodaravadhani

Please update the test cases. Currently we cannot use the generated cmdlets and SDK based cmdlets at the same test case.

wyunchi-ms avatar Sep 19 '22 04:09 wyunchi-ms

Hey @wyunchi-ms, Thanks for the review. But, I have made sure the tests have only manual cmdlets. Could you point to a test that might be using a combination of both ? The psd1 file contains only the manual ones that we want to keep for now.

damodaravadhani avatar Sep 19 '22 04:09 damodaravadhani

Close this due to https://github.com/Azure/azure-powershell/pull/19643 is merged.

wyunchi-ms avatar Sep 27 '22 04:09 wyunchi-ms