azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Fixed a bug that does not return HubIPAddresses' PrivateIPAddress during a Get-AzFirewall command

Open Gizachew-Eshetie opened this issue 2 years ago • 10 comments

Description

Checklist

  • [x] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Gizachew-Eshetie avatar Aug 25 '22 23:08 Gizachew-Eshetie

This PR introduce breaking changes. Please supress the breaking change first for the PR.

wyunchi-ms avatar Sep 13 '22 08:09 wyunchi-ms

This PR introduce breaking changes. Please supress the breaking change first for the PR.

@wyunchi-ms Done.

Gizachew-Eshetie avatar Sep 13 '22 22:09 Gizachew-Eshetie

/azp run azure-powershell - security-tools

wyunchi-ms avatar Sep 15 '22 08:09 wyunchi-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 15 '22 08:09 azure-pipelines[bot]

/azp run azure-powershell - security-tools

wyunchi-ms avatar Sep 19 '22 08:09 wyunchi-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 19 '22 08:09 azure-pipelines[bot]

/azp run azure-powershell - powershell-core

wyunchi-ms avatar Sep 20 '22 01:09 wyunchi-ms

/azp run azure-powershell - security-tools

wyunchi-ms avatar Sep 20 '22 01:09 wyunchi-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 20 '22 01:09 azure-pipelines[bot]

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 20 '22 01:09 azure-pipelines[bot]

/azp run azure-powershell - powershell-core

wyunchi-ms avatar Sep 23 '22 01:09 wyunchi-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 23 '22 01:09 azure-pipelines[bot]