azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Merge Azure Virtual Network Manager Cmdlets

Open jago2136 opened this issue 2 years ago • 5 comments

Description

Checklist

  • [X] Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:
  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from the scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT change version of module in pull request

jago2136 avatar Jul 22 '22 17:07 jago2136

Proposal for these changes here https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1220

jago2136 avatar Jul 22 '22 22:07 jago2136

Hi @jago2136 I remember we have a preview branch for Network Manager. Is it possible to merge that branch into network-2022 first. And then merge new changes? Too many changes in this PR. It's hard to review for me.

BethanyZhou avatar Jul 25 '22 07:07 BethanyZhou

@jago2136 please fix conflicts

BethanyZhou avatar Aug 01 '22 04:08 BethanyZhou

@jago2136 Hi, please resolve the comments above. Besides, if you need to request an out-of-band release, please refer to Out of Band (OOB) Release Process and submit a request. Otherwise we will release it on September 9th.

Also, when regenerating help documents, please make sure to add -RefreshModulePage parameter. Az.Network.md is expected to be updated.

isra-fel avatar Aug 01 '22 07:08 isra-fel

I've addressed all comments and resolved merge conflicts. Please review again, thank you!

jago2136 avatar Aug 04 '22 01:08 jago2136

/azp run azure-powershell - security-tools

BethanyZhou avatar Aug 12 '22 01:08 BethanyZhou

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 12 '22 01:08 azure-pipelines[bot]