azure-powershell
azure-powershell copied to clipboard
Merge Azure Virtual Network Manager Cmdlets
Description
Checklist
- [X] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:
-
SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to
generation
branch. - SHOULD make the title of PR clear and informative, and in the present imperative tense.
-
SHOULD update
ChangeLog.md
file(s) appropriately- For any service, the
ChangeLog.md
file can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the
## Upcoming Release
header in the past tense. Add changelog in description section if PR goes intogeneration
branch. - Should not change
ChangeLog.md
if no new release is required, such as fixing test case only.
- For any service, the
-
SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
- Create new module from the scratch
- Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
- Create new resource type which name doesn't use module name as prefix
- Have design question before implementation
- SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
- SHOULD have proper test coverage for changes in pull request.
- SHOULD NOT introduce breaking changes in Az minor release except preview version.
- SHOULD NOT change version of module in pull request
Proposal for these changes here https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1220
Hi @jago2136 I remember we have a preview branch for Network Manager. Is it possible to merge that branch into network-2022 first. And then merge new changes? Too many changes in this PR. It's hard to review for me.
@jago2136 please fix conflicts
@jago2136 Hi, please resolve the comments above. Besides, if you need to request an out-of-band release, please refer to Out of Band (OOB) Release Process and submit a request. Otherwise we will release it on September 9th.
Also, when regenerating help documents, please make sure to add -RefreshModulePage
parameter. Az.Network.md
is expected to be updated.
I've addressed all comments and resolved merge conflicts. Please review again, thank you!
/azp run azure-powershell - security-tools
Azure Pipelines successfully started running 1 pipeline(s).