azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Create .editorconfig

Open JanuszNowak opened this issue 2 years ago • 5 comments

Create .editorconfig for applying code formatting add basic rule trim_trailing_whitespace = true

Description

Checklist

  • [x ] I have read the Submitting Changes section of CONTRIBUTING.md
  • [ x] The title of the PR is clear and informative
  • [ ] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [x] The PR does not introduce breaking changes
  • [x] If applicable, the changes made in the PR have proper test coverage
  • [ ] For public API changes to cmdlets:
    • [ ] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • [ ] the markdown help files have been regenerated using the commands listed here

JanuszNowak avatar Jul 09 '22 18:07 JanuszNowak

Thank you for your contribution JanuszNowak! We will review the pull request and get back to you soon.

ghost avatar Jul 09 '22 18:07 ghost

Hi @JanuszNowak , what's the config used for what code editor? BTW, why you intent to merge your code into preview branch?

BethanyZhou avatar Jul 11 '22 08:07 BethanyZhou

@BethanyZhou I used editorconfig.org with is integrating with multiple editors GUI and CLI's, my mistake to merge to preview, with branch I suppose to merge ?

JanuszNowak avatar Jul 12 '22 18:07 JanuszNowak

Hi @JanuszNowak , sorry for late response. Targeted your PR to main branch. Could you rebase your PR to main branch. Many unexpected commits are carried from preview branch.

BethanyZhou avatar Jul 20 '22 06:07 BethanyZhou

Hi @JanuszNowak , there are too many commits here. Do you mind rebase your branch? Thanks!

wyunchi-ms avatar Sep 06 '22 03:09 wyunchi-ms

@JanuszNowak Thanks for the contribution. However, since your PR branch is too far behind the main branch, please cherry pick it above the latest main and submit a new PR.

msJinLei avatar Apr 26 '23 08:04 msJinLei