azure-powershell icon indicating copy to clipboard operation
azure-powershell copied to clipboard

Published 20 hours ago • verified publisher icon Azure

[Az.DataProtection] Added Grant permissions for all workloads

Open rishit-microsoft opened this issue 2 years ago • 15 comments

Description

Added Grant permissions for all workloads

Checklist

  • [x] I have read the Submitting Changes section of CONTRIBUTING.md
  • [x] The title of the PR is clear and informative
  • [x] The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • [x] The PR does not introduce breaking changes
  • [x] If applicable, the changes made in the PR have proper test coverage
  • [x] For public API changes to cmdlets:
    • [x] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • [x] the markdown help files have been regenerated using the commands listed here

rishit-microsoft avatar Jun 10 '22 10:06 rishit-microsoft

Thank you for your contribution rishit-microsoft! We will review the pull request and get back to you soon.

msftbot[bot] avatar Jun 10 '22 10:06 msftbot[bot]

CLA assistant check
All CLA requirements met.

ghost avatar Jun 10 '22 10:06 ghost

there is an OOB going on for https://github.com/Azure/sdk-release-request/issues/2905 is this PR also need to be included in OOB release?

VeryEarly avatar Jun 14 '22 06:06 VeryEarly

/azp run azure-powershell - powershell-core

VeryEarly avatar Jun 16 '22 23:06 VeryEarly

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 16 '22 23:06 azure-pipelines[bot]

/azp run azure-powershell - powershell-core

VeryEarly avatar Jun 17 '22 05:06 VeryEarly

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 17 '22 05:06 azure-pipelines[bot]

there is an OOB going on for Azure/sdk-release-request#2905 is this PR also need to be included in OOB release?

not needed. This PR would go in regular release cycle

hiaga avatar Jun 20 '22 06:06 hiaga

@rishit-microsoft build is failing, please check

hiaga avatar Jun 30 '22 06:06 hiaga

@BethanyZhou : Can you please review this PR. I've currently removed the signature changes because it is causing the build to fail, Please suggest how to suppress the Static analysis failure

hiaga avatar Jul 08 '22 03:07 hiaga

Comments are not resolved but conversations were marked as resolved. Did you forget to push commit here?

BethanyZhou avatar Jul 20 '22 07:07 BethanyZhou

Kindly ping @rishit-microsoft Also please join Azure Orgnization here https://aka.ms/AzureGitHub

isra-fel avatar Aug 02 '22 05:08 isra-fel

Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀

isra-fel avatar Aug 16 '22 06:08 isra-fel

@isra-fel @BethanyZhou apologies for leaving the PR inactive for quite sometime, we were focusing on some other PS deliverables in the meantime. This PR was almost ready, I'll upload the commit after resolving comments and will now work towards its closure.

hiaga avatar Sep 15 '22 03:09 hiaga

So there will be two KeyVault in Postgres server scemario?

no, only one key vault and one backup vault. backup vault is by default used in all data protection commands

-VaultName <String> -VaultResourceGroup <String> - this inputs the backup vault for all scenarios

[-KeyVaultId <String>] - this inputs the key vault for Postgres server scenario

hiaga avatar Sep 21 '22 02:09 hiaga