Update Azure Virtual desktop Scaling Plan Cmdlets to version 2021-09-03-preview

[dallinlmag]

Description

We needed to change the format of the schedule object attached to scaling plans in Desktop Virtualization. We are in public preview, and the changes have been added to the rest api. The powershell changes were done using autorest. We discussed with the powershell team about this breaking change and were given permission to continue because we don't have any customers using the powershell at the moment.

Checklist

• [x] I have read the Submitting Changes section of CONTRIBUTING.md
• [x] The title of the PR is clear and informative
• [ ] The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• [ ] The PR does not introduce breaking changes
• [x] If applicable, the changes made in the PR have proper test coverage
• [ ] For public API changes to cmdlets:
  • [ ] a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • {Please put the link here}
  • [ ] the markdown help files have been regenerated using the commands listed here

[dallinlmag]

This is a revised copy of his now closed PR https://github.com/Azure/azure-powershell/pull/16584.

[msJinLei]

  D:\a\1\s\artifacts//StaticAnalysisResults\BreakingChangeIssues.csv Errors
  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Az.DesktopVirtualization","Get-AzWvdDesktop","Get-AzWvdDesktop","0","1020","The cmdlet 'Get-AzWvdDesktop' no longer has output type 'Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20210712.IDesktopList'.","Make cmdlet 'Get-AzWvdDesktop' return type 'Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20210712.IDesktopList'."
  "Az.DesktopVirtualization","Get-AzWvdRegistrationInfo","Get-AzWvdRegistrationInfo","0","1020","The cmdlet 'Get-AzWvdRegistrationInfo' no longer has output type 'Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20210712.RegistrationInfo'.","Make cmdlet 'Get-AzWvdRegistrationInfo' return type 'Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20210712.RegistrationInfo'."
  "Az.DesktopVirtualization","New-AzWvdScalingPlan","New-AzWvdScalingPlan","0","2020","The cmdlet 'New-AzWvdScalingPlan' no longer supports the type 'Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Support.HostPoolType' for parameter 'HostPoolType'.","Change the type for parameter 'HostPoolType' back to 'Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Support.HostPoolType'."
  "Az.DesktopVirtualization","Update-AzWvdScalingPlan","Update-AzWvdScalingPlan","0","2000","The cmdlet 'Update-AzWvdScalingPlan' no longer supports the parameter 'HostPoolType' and no alias was found for the original parameter name.","Add the parameter 'HostPoolType' back to the cmdlet 'Update-AzWvdScalingPlan', or add an alias to the original parameter name."
  "Az.DesktopVirtualization","Update-AzWvdScalingPlan","Update-AzWvdScalingPlan","0","1050","The parameter set 'UpdateExpanded' for cmdlet 'Update-AzWvdScalingPlan' has been removed.","Add parameter set 'UpdateExpanded' back to cmdlet 'Update-AzWvdScalingPlan'."
  "Az.DesktopVirtualization","Update-AzWvdScalingPlan","Update-AzWvdScalingPlan","0","1050","The parameter set 'UpdateViaIdentityExpanded' for cmdlet 'Update-AzWvdScalingPlan' has been removed.","Add parameter set 'UpdateViaIdentityExpanded' back to cmdlet 'Update-AzWvdScalingPlan'."
  "Az.DesktopVirtualization","Update-AzWvdScalingPlan","Update-AzWvdScalingPlan","0","1050","The parameter set '__AllParameterSets' for cmdlet 'Update-AzWvdScalingPlan' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'Update-AzWvdScalingPlan'."
  
  D:\a\1\s\artifacts//StaticAnalysisResults\SignatureIssues.csv Errors
  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "Az.DesktopVirtualization","Get-AzWvdRegistrationInfo","Get-AzWvdRegistrationInfo","1","8600","Cmdlet 'Get-AzWvdRegistrationInfo' has no defined output type.","Add an OutputType attribute that declares the type of the object(s) returned by this cmdlet. If this cmdlet returns no output, please set the output type to 'bool' and make sure to implement the 'PassThru' parameter."

[msJinLei]

@dallinlmag please submit a cmdlet review first https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues

[dallinlmag]

@msJinLei cmdlet review submitted here: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1139 thanks

[BethanyZhou]

CI failed. Please have a look.

[BethanyZhou]

Hi @dallinlmag , please remove or hide these cmdlets by directives in README.md. If not, these files will still be generated.

[dallinlmag]

@BethanyZhou I have removed the files that you asked to delete. Is there anything else that needs to be addressed before this is accepted?

[BethanyZhou]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[BethanyZhou]

Could you provide a change log for your change?

[isra-fel]

Hi @dallinlmag , 3 things left before we can merge this:

• Please check all the scripts in custom/ and make sure all the api versions are up to date. Here's an example where it's not.
• Please follow these instructions to suppress the error messages about breaking changes
• We update the changelog whenever there's a new release, so please write something in the comments which we can put in https://github.com/Azure/azure-powershell/blob/main/src/DesktopVirtualization/ChangeLog.md

[isra-fel]

Kindly ping @dallinlmag

[isra-fel]

Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀