azure-kusto-spark icon indicating copy to clipboard operation
azure-kusto-spark copied to clipboard

Fix Issue #261

Open ag-ramachandran opened this issue 2 years ago • 5 comments

Changes:

When creating buildScan operation, if the user explicitly uses the ForceSingleMode operation , always honor the single mode and do not fallback to distributed mode. This means that if ForceSingleMode is used and the query fails or times out the source operation will fail without fallback

In the earlier revision, if the ForcesingleMode is specified and the query fails, it will fallback to the ForceDistributedMode

Fixes issue #261

ag-ramachandran avatar Sep 28 '22 11:09 ag-ramachandran

Apart from the core method that needed change (buildscan) , the 2 accessor methods have been refactored to avoid lint errors and make them consistent with scala

ag-ramachandran avatar Sep 28 '22 11:09 ag-ramachandran

Please call these by the real change and add a description of what the change is and only add that it solves the issue at last line of the description. Also if you use '#' before the number it will link to the issue itself

ohadbitt avatar Sep 28 '22 11:09 ohadbitt

Please call these by the real change and add a description of what the change is and only add that it solves the issue at last line of the description. Also if you use '#' before the number it will link to the issue itself

My bad, added a description of the behavior and linked the issue.

ag-ramachandran avatar Sep 28 '22 11:09 ag-ramachandran

lets add to the documentation that we suggest to provide a value here as estimation can take up to 6 seconds - or is too much details for a user?

ohadbitt avatar Sep 28 '22 11:09 ohadbitt

lets add to the documentation that we suggest to provide a value here as estimation can take up to 6 seconds - or is too much details for a user?

I will add it as a note in the readme as ell

ag-ramachandran avatar Oct 03 '22 12:10 ag-ramachandran