azure-kusto-java icon indicating copy to clipboard operation
azure-kusto-java copied to clipboard

Retry loading ResourceManager resources in all cases

Open yihezkel opened this issue 1 year ago • 3 comments

Changed

Retry loading ResourceManager resources in all cases

yihezkel avatar Feb 05 '24 17:02 yihezkel

Test Results

321 tests  +1   313 :white_check_mark: +1   3m 7s :stopwatch: -1s  25 suites ±0     8 :zzz: ±0   25 files   ±0     0 :x: ±0 

Results for commit 28c4f393. ± Comparison against base commit 626edb27.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
com.microsoft.azure.kusto.ingest.ResourceManagerTest ‑ getIngestionResource_AggregationQueue_VerifyRoundRubin
com.microsoft.azure.kusto.ingest.ResourceManagerTest ‑ getIngestionResource_TempStorage_VerifyRoundRubin
com.microsoft.azure.kusto.ingest.ResourceManagerTest ‑ getIngestionResource_AggregationQueue_VerifyRoundRobin
com.microsoft.azure.kusto.ingest.ResourceManagerTest ‑ getIngestionResource_TempStorage_VerifyRoundRobin
com.microsoft.azure.kusto.ingest.ResourceManagerTimerTest ‑ timerTestFailureGettingResources

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 06 '24 17:02 github-actions[bot]

Codecov Report

Attention: Patch coverage is 79.72028% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 57.25%. Comparing base (0783b1c) to head (e588e13).

Files Patch % Lines
.../microsoft/azure/kusto/ingest/ResourceManager.java 79.72% 21 Missing and 8 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #349      +/-   ##
============================================
+ Coverage     56.80%   57.25%   +0.44%     
+ Complexity      818      805      -13     
============================================
  Files           109      109              
  Lines          4112     4131      +19     
  Branches        444      447       +3     
============================================
+ Hits           2336     2365      +29     
+ Misses         1586     1576      -10     
  Partials        190      190              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 10 '24 12:03 codecov[bot]

Codecov Report

Attention: Patch coverage is 79.72028% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 57.25%. Comparing base (d112a99) to head (e588e13). Report is 4 commits behind head on master.

:exclamation: Current head e588e13 differs from pull request most recent head 28c4f39

Please upload reports for the commit 28c4f39 to get more accurate results.

Files Patch % Lines
.../microsoft/azure/kusto/ingest/ResourceManager.java 79.72% 21 Missing and 8 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #349      +/-   ##
============================================
- Coverage     58.72%   57.25%   -1.48%     
+ Complexity      838      805      -33     
============================================
  Files           111      109       -2     
  Lines          4068     4131      +63     
  Branches        428      447      +19     
============================================
- Hits           2389     2365      -24     
- Misses         1484     1576      +92     
+ Partials        195      190       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 31 '24 13:03 codecov-commenter

@ohadbitt I made a lot of changes here, and you've worked in this area before, so just a head's up in case you want to review.

@AsafMah I made a few changes since your approval, so a head's up in case you want to rereview.

yihezkel avatar May 19 '24 20:05 yihezkel