azure-functions-templates icon indicating copy to clipboard operation
azure-functions-templates copied to clipboard

Updated durable functions templates in C# to use nameof

Open lbugnion opened this issue 5 years ago • 2 comments

This uses nameof wherever possible instead of magic strings. This makes navigating to the symbols (F12 in Visual Studio) much easier and more convenient. It also avoids errors when renaming a method.

lbugnion avatar Nov 03 '20 19:11 lbugnion

Thanks @lbugnion.

cc @cgillum @ConnorMcMahon

anthonychu avatar Nov 03 '20 19:11 anthonychu

Thanks for your contribution. This seems right to me but, before merging, I think it'd be good to check-in with @AnatoliB and @cgillum as to whether or not we want to incorporate this pattern into the templates. If possible, I'd like to wait until they can give this an approval themselves :)

davidmrdavid avatar Dec 14 '21 19:12 davidmrdavid

Thanks for your contribution. This seems right to me but, before merging, I think it'd be good to check-in with @AnatoliB and @cgillum as to whether or not we want to incorporate this pattern into the templates. If possible, I'd like to wait until they can give this an approval themselves :)

@davidmrdavid @AnatoliB @cgillum - any thoughts on this before we merge?

liliankasem avatar Sep 28 '22 22:09 liliankasem

My advice still stands: I like the change, but I want to get at least one more DF person to approve since this affects our quickstart experience. I'll wait for either of the tagged folks above to chime in :-)

davidmrdavid avatar Sep 28 '22 23:09 davidmrdavid

@liliankasem go ahead and merge then!

davidmrdavid avatar Sep 28 '22 23:09 davidmrdavid