azure-functions-python-worker
azure-functions-python-worker copied to clipboard
refactor: Remove custom targets, use 'None' item group
Description
This PR refactors the python worker nuget package targets as follows:
- Removes current custom targets/properties
- Properties, items, targets all share the same global namespace. Naming these generally increases risk of conflicts with other props/items/targets.
- Leverages
None
item group with appropriate metadata to haveCopyToOutputDirectory
andCopyToPublishDirectory
targets perform the copies for us.- Instead of copying files to output or publish manually, you can add to various existing item groups and tag them to be copied.
- This change improves incremental build support, avoiding copies when the files already exist at the destination.
- Adds additional logic to copy only specific runtime files with a runtime identifier is specified.
- Will error out if the runtime identifier is not supported.
PR information
- [x] The title of the PR is clear and informative.
- [x] There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
- [ ] If applicable, the PR references the bug/issue that it fixes in the description.
- [ ] New Unit tests were added for the changes made and CI is passing.
Quality of Code and Contribution Guidelines
- [x] I have read the contribution guidelines.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 45.88%. Comparing base (
c244569
) to head (2f40dbd
). Report is 3 commits behind head on dev.
:exclamation: Current head 2f40dbd differs from pull request most recent head 6586aaf
Please upload reports for the commit 6586aaf to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## dev #1472 +/- ##
===========================================
- Coverage 83.03% 45.88% -37.15%
===========================================
Files 36 35 -1
Lines 2322 2040 -282
Branches 346 302 -44
===========================================
- Hits 1928 936 -992
- Misses 295 1028 +733
+ Partials 99 76 -23
Flag | Coverage Δ | |
---|---|---|
unittests | 45.88% <ø> (-37.15%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.