azure-functions-kafka-extension icon indicating copy to clipboard operation
azure-functions-kafka-extension copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Enable setting compression via the KafkaAttribute

Open gliljas opened this issue 5 years ago • 9 comments

gliljas avatar Sep 17 '20 09:09 gliljas

Hi @gliljas

Thank you for your contribution. The code looks good. Could you update the documentation on our Readme?

TsuyoshiUshio avatar Oct 06 '20 00:10 TsuyoshiUshio

Documentation added.

Please note that I also fixed all the nullable properties on KafkaAttribute. Nullable properties are unusable on attributes.

gliljas avatar Oct 31 '20 22:10 gliljas

@TsuyoshiUshio As mentioned, this fixes a bug in the current attribute, which makes quite a few of the attribute parameters completely useless.

gliljas avatar Nov 05 '20 08:11 gliljas

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

ghost avatar Mar 13 '21 00:03 ghost

Hi @gliljas and @fbeltrao What is the current status? No rush, however I'm curious. I'm preparing to release 3.3.0. :) I'll release it on this weekend. If this feature coming, I'll include it on the next release.

TsuyoshiUshio avatar Mar 26 '21 18:03 TsuyoshiUshio

Rebased on dev and reverted controversial stuff.

gliljas avatar Jul 08 '22 16:07 gliljas

@gliljas could you please close these comments, I am happy to close this PR and accept your contribution. Could you resolve the comments. You can open a fresh PR also if this contribution lost history Moreover, you also need to address the regression.

Add the description also to define the scope of the PR

shrohilla avatar Dec 13 '22 17:12 shrohilla

/azp run

shrohilla avatar Dec 13 '22 17:12 shrohilla

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 13 '22 17:12 azure-pipelines[bot]