azure-functions-kafka-extension icon indicating copy to clipboard operation
azure-functions-kafka-extension copied to clipboard

Published 20 hours ago • verified publisher icon Azure

The event Timestamp should be a DateTimeOffset

Open gliljas opened this issue 5 years ago • 2 comments

Maybe a minor thing, but I think all (?) modern libraries should move to DateTimeOffset, instead of DateTime. It's a much better datatype and it's what's recommended by the Framework Design Guidelines.

gliljas avatar Sep 10 '20 08:09 gliljas

It seems confluent-kafka-dotnet is using the DateTime. https://github.com/confluentinc/confluent-kafka-dotnet/search?p=2&q=DateTime&unscoped_q=DateTime

However, what you said is true. Thank you for sharing. I can't prioritize this now. However, keep this issue as open.

TsuyoshiUshio avatar Sep 16 '20 21:09 TsuyoshiUshio

https://github.com/confluentinc/confluent-kafka-dotnet/pull/1408

gliljas avatar Sep 17 '20 19:09 gliljas