azure-functions-host
azure-functions-host copied to clipboard
Issue #8015: Remove TraceWriter from samples/usage
TraceWriter
is deprecated but remains in the testing and samples path, driving more adoption then we want probably (see #8015) - prepping a PR in case we want to execute on #8015 and remove some noise. Or, there's a reason to keep it and this commit is useless :)
This reduces the usage down to the 1 place we want to ensure TraceWriter
vs. ILogger
is working correctly.
Issue describing the changes in this PR
Resolves #8015.
Pull request checklist
- [x] My changes do not require documentation changes
- [ ] Otherwise: Documentation issue linked to PR
- [x] My changes should not be added to the release notes for the next release
- [ ] Otherwise: I've added my notes to
release_notes.md
- [ ] Otherwise: I've added my notes to
- [x] My changes do not need to be backported to a previous version
- [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
- [x] I have added all required tests (Unit tests, E2E tests)
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Pending test run fixes in #8051
Finally getting to this during triage (somehow this fell through the cracks). Are we leaving at least a test that validates that TraceWriter
continues to work? For the rest of them, this is a good change.
@fabiocav I'll try and pull this during the week to update to latest - pretty sure I intentionally left 1 test in to make sure that works but will double check.
@fabiocav I'll try and pull this during the week to update to latest - pretty sure I intentionally left 1 test in to make sure that works but will double check.
Any updates on this? Would love to get this merged :)
Merged dev in to ensure latest - confirmed this is still being tested in several places to ensure compatibility (e.g. \test\WebJobs.Script.Tests.Integration\TestScripts\CSharp\Scenarios\run.csx
and others)
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@NickCraver looks like there are still some pipeline issues to fix, otherwise should be good to merge!
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.