azure-functions-host icon indicating copy to clipboard operation
azure-functions-host copied to clipboard

Issue #8015: Remove TraceWriter from samples/usage

Open NickCraver opened this issue 3 years ago • 11 comments

TraceWriter is deprecated but remains in the testing and samples path, driving more adoption then we want probably (see #8015) - prepping a PR in case we want to execute on #8015 and remove some noise. Or, there's a reason to keep it and this commit is useless :)

This reduces the usage down to the 1 place we want to ensure TraceWriter vs. ILogger is working correctly.

Issue describing the changes in this PR

Resolves #8015.

Pull request checklist

  • [x] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [x] My changes should not be added to the release notes for the next release
    • [ ] Otherwise: I've added my notes to release_notes.md
  • [x] My changes do not need to be backported to a previous version
    • [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [x] I have added all required tests (Unit tests, E2E tests)

NickCraver avatar Jan 06 '22 18:01 NickCraver

/azp run

NickCraver avatar Jan 06 '22 18:01 NickCraver

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 06 '22 18:01 azure-pipelines[bot]

/azp run

NickCraver avatar Jan 10 '22 22:01 NickCraver

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jan 10 '22 22:01 azure-pipelines[bot]

Pending test run fixes in #8051

NickCraver avatar Jan 11 '22 21:01 NickCraver

Finally getting to this during triage (somehow this fell through the cracks). Are we leaving at least a test that validates that TraceWriter continues to work? For the rest of them, this is a good change.

fabiocav avatar May 18 '22 20:05 fabiocav

@fabiocav I'll try and pull this during the week to update to latest - pretty sure I intentionally left 1 test in to make sure that works but will double check.

NickCraver avatar May 23 '22 22:05 NickCraver

@fabiocav I'll try and pull this during the week to update to latest - pretty sure I intentionally left 1 test in to make sure that works but will double check.

Any updates on this? Would love to get this merged :)

liliankasem avatar Jun 06 '22 18:06 liliankasem

Merged dev in to ensure latest - confirmed this is still being tested in several places to ensure compatibility (e.g. \test\WebJobs.Script.Tests.Integration\TestScripts\CSharp\Scenarios\run.csx and others)

NickCraver avatar Jun 09 '22 17:06 NickCraver

/azp run

fabiocav avatar Jul 06 '22 17:07 fabiocav

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 06 '22 17:07 azure-pipelines[bot]

/azp run

liliankasem avatar Aug 18 '22 17:08 liliankasem

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 18 '22 17:08 azure-pipelines[bot]

@NickCraver looks like there are still some pipeline issues to fix, otherwise should be good to merge!

liliankasem avatar Sep 12 '22 17:09 liliankasem

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

ghost avatar Sep 19 '22 19:09 ghost