azure-functions-host icon indicating copy to clipboard operation
azure-functions-host copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Builds: How should builds from forks work?

Open NickCraver opened this issue 2 years ago • 4 comments

In opening a few PRs yesterday (#7917, #7919, #7920) , we noticed that PR builds weren't allowed from forks at all. I have permissions so we tried /azp run but building from forks was not allowed. This is allowed in the WebJobs SDK repo but not in the Host.

There are 2 issues:

  1. Builds are not allowed on forks at all.
  2. If they are allowed, even with the full-ci label, secrets aren't allowed to the forks.

Overall, this means external contributors aren't able to file PRs that we're able to run checks on. Creating this issue to find a best path on resolving this (I'm happy to help chase this down).

cc @liliankasem @brettsam @fabiocav

NickCraver avatar Dec 01 '21 14:12 NickCraver

@amamounelsayed @VpOfEngineering is this something you can help with? @fabiocav and I were discussing maybe setting up another pipeline for external contributions that does basic validation?

liliankasem avatar Dec 01 '21 17:12 liliankasem

@amamounelsayed @VpOfEngineering this is something that is missing after our move from AppVeyor. Happy to sync on this if it helps.

fabiocav avatar Dec 01 '21 19:12 fabiocav

I'll set up some time @fabiocav - this is something @pragnagopa and I have run into before.

VpOfEngineering avatar Dec 01 '21 19:12 VpOfEngineering

@VpOfEngineering @fabiocav - any updates on this? Happy to help where I can too

liliankasem avatar Feb 03 '22 20:02 liliankasem