azure-functions-host icon indicating copy to clipboard operation
azure-functions-host copied to clipboard

Forwarding the LanguageWorkerOptions from the host to the job host scope and ensuring we use the provided instances.

Open fabiocav opened this issue 1 year ago • 3 comments

Issue describing the changes in this PR

Addressing an issue leading to double initialization of worker configuration and profile evaluation.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • [ ] Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • [x] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [x] My changes should not be added to the release notes for the next release
    • [ ] Otherwise: I've added my notes to release_notes.md
  • [x] My changes do not need to be backported to a previous version
    • [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [x] My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • [x] I have added all required tests (Unit tests, E2E tests)

fabiocav avatar Aug 06 '24 00:08 fabiocav

Is it possible to add tests to validate this change?

liliankasem avatar Sep 10 '24 21:09 liliankasem

@brettsam Ping on the review.

kshyju avatar Sep 28 '24 15:09 kshyju

@jviau / @brettsam / @liliankasem I'm reviewing the latest changes, and will take point on addressing any feedback.

fabiocav avatar Oct 08 '24 18:10 fabiocav

Rebased on dev.

kshyju avatar Jan 29 '25 18:01 kshyju