azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

When local.settings.json is absent, runnig func host start does not work for newer worker models #3544

Open VineethReyya opened this issue 1 year ago • 2 comments

Issue describing the changes in this PR

-> when local.settings.json is absent. Scenario1: running 'func host start' will Display Available WorkerRuntime on the screen and user can select the Runtime from the list so the FUNCTION_WORKER_RUNTIME setting is added and start hosting the function app Scenario2: running 'func host start --{WorkerRuntime}' will add FUNCTION_WORKER_RUNTIME setting and start hosting the function app.

resolves #3544

Pull request checklist

  • [x] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [x] My changes do not need to be backported to a previous version
    • [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [x] I have added all required tests (Unit tests, E2E tests)

VineethReyya avatar Sep 25 '24 06:09 VineethReyya

Thanks for working on this! Could you also check if this approach works when the core tools are started by the Static Web Apps CLI? I'm afraid the terminal might not be TTY in that case, and would then not allow user interactions.

SWA CLI is used in many of our samples along with the Functions emulators, so this would still remain an issue.

sinedied avatar Sep 27 '24 10:09 sinedied

Thanks for working on this! Could you also check if this approach works when the core tools are started by the Static Web Apps CLI? I'm afraid the terminal might not be TTY in that case, and would then not allow user interactions.

SWA CLI is used in many of our samples along with the Functions emulators, so this would still remain an issue.

Thanks for the suggestion. will look into it

VineethReyya avatar Sep 30 '24 05:09 VineethReyya

this PR is refreshed with new PR

VineethReyya avatar Nov 06 '24 08:11 VineethReyya