azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

fix: gozip across different host OS architectures

Open mxschmitt opened this issue 1 year ago • 2 comments

Before for e.g. macOS or Windows the gozip executable did not match the target OS architecture. This PR fixes that:

image

Issue describing the changes in this PR

Fixes https://github.com/Azure/azure-functions-core-tools/issues/3648

Pull request checklist

  • [x] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [ ] My changes do not need to be backported to a previous version
    • [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [ ] I have added all required tests (Unit tests, E2E tests)

cc @arroyc

mxschmitt avatar Apr 24 '24 19:04 mxschmitt

@khkh-ms / @amamounelsayed Please review/accept this fix - this is a blocker for me on an M2 Mac. Thanks!

drew1326 avatar May 22 '24 22:05 drew1326

@drew1326 as a temporary workaround, you can manually build the gozip binary & replace it.

onexbash avatar May 26 '24 09:05 onexbash

/azp run coretools.public

fabiocav avatar Sep 18 '24 03:09 fabiocav

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 18 '24 03:09 azure-pipelines[bot]

@fabiocav pushed a fix (https://github.com/Azure/azure-functions-core-tools/pull/3650/commits/481986aa63e37eed5be72a42d9216254c2ba1319) which started failing after https://github.com/Azure/azure-functions-core-tools/commit/a0fe7af153470e291ba316c9840a324ae2dc9923.

mxschmitt avatar Sep 18 '24 08:09 mxschmitt

/azp run coretools.public

fabiocav avatar Sep 18 '24 20:09 fabiocav

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 18 '24 20:09 azure-pipelines[bot]

Thank you, @mxschmitt ! Re-running the build to make sure we're green.

fabiocav avatar Sep 18 '24 20:09 fabiocav

Thank you, @mxschmitt , for the contribution and the patience!

fabiocav avatar Sep 19 '24 03:09 fabiocav

Is there a nightly build from where I can grab the correct gozip executable? Current latest 4.06280 seems to be affected by the bug.

Edit: Otherwise, is this the gozip that needs to be compiled and replace the wrong one? https://github.com/sanderhahn/gozip

ldibanyez avatar Oct 22 '24 15:10 ldibanyez