azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

updating .NET templates and updating .NET model prompts

Open mattchenderson opened this issue 1 year ago • 10 comments

resolves #3603

Also cleans up some label inconsistency and leads with the isolated worker model in prompting.

Pull request checklist

  • [X] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [X] My changes do not need to be backported to a previous version
    • [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [X] I have added all required tests (Unit tests, E2E tests)

mattchenderson avatar Mar 06 '24 02:03 mattchenderson

I assert that the build errors are unrelated to my changes, as the same thing is happening in other PRs, and it comes from a code path that I did not touch.

mattchenderson avatar Mar 06 '24 04:03 mattchenderson

/azp run

khkh-ms avatar Mar 06 '24 19:03 khkh-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 06 '24 19:03 azure-pipelines[bot]

@khkh-ms checking back on this. What's needed to get this one in?

mattchenderson avatar Mar 18 '24 20:03 mattchenderson

/azp run

khkh-ms avatar Mar 19 '24 06:03 khkh-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 19 '24 06:03 azure-pipelines[bot]

PR are now passing in the pipeline. I will do another try for the build. I will recommend that you get latest from v4.x into your branch if it is not working.

khkh-ms avatar Mar 19 '24 06:03 khkh-ms

@khkh-ms, I pushed a rebase, but still seems off, and I see the same happening for "current build" too.

mattchenderson avatar Mar 20 '24 18:03 mattchenderson

Thanks! I will run the failing tests locally today/tomorrow and fix the tests if needed.

khuramhd avatar Mar 20 '24 19:03 khuramhd

Any updates @khkh-ms ?

mattchenderson avatar Mar 25 '24 19:03 mattchenderson

This PR now removes a test, reintroduction of which is related to #3644

mattchenderson avatar Apr 16 '24 20:04 mattchenderson

/azp run

khkh-ms avatar Apr 17 '24 15:04 khkh-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 17 '24 15:04 azure-pipelines[bot]