azure-functions-core-tools
azure-functions-core-tools copied to clipboard
Upgrade storage client & support Entra identities for storage in more scenarios
Issue describing the changes in this PR
Resolves #3376
Pull request checklist
- [ ] My changes do not require documentation changes
- [ ] Otherwise: Documentation issue linked to PR
- [ ] My changes do not need to be backported to a previous version
- [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
- [ ] I have added all required tests (Unit tests, E2E tests)
PR overview:
- Upgrade to the latest Storage client
- Use
AzureCliCredentialandAzurePowerShellCredentialto fetch an access token instead of the code that calls the CLIs- Note I intentionally did not use
DefaultAzureCredentialto preserve the current behavior, as it might require the user to specify a tenant ID under certain conditions
- Note I intentionally did not use
- Support
AzureWebJobsStorage__accountNamein more scenarios:- Linux Consumption - fetches the storage account key using ARG+ARM and uses it to create the required SAS URI
- Linux Elastic - combined code with Dedicated, as both support run from package
- Remove old unused app.config (.NET Framework relic)
I would be awesome if this could get merged & released. Making my storage account accessible via managed identity only led me to this PR, due to this not being merged yet I was forced to switch to WEBSITE_RUN_FROM_PACKAGE which seems to ignore requirements.txt which in turn leads to all kinds of other failures (see https://github.com/Azure/azure-functions-python-worker/issues/1262 for a fun example) and a lot of wasted time. I'd love to see this merged.
@Azure/azure-functions-worker-owners @mattchenderson PTAL
Closing as this branch has become stale.