azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

Upgrade storage client & support Entra identities for storage in more scenarios

Open aelij opened this issue 1 year ago • 2 comments

Issue describing the changes in this PR

Resolves #3376

Pull request checklist

  • [ ] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [ ] My changes do not need to be backported to a previous version
    • [ ] Otherwise: Backport tracked by issue/PR #issue_or_pr
  • [ ] I have added all required tests (Unit tests, E2E tests)

PR overview:

  • Upgrade to the latest Storage client
  • Use AzureCliCredential and AzurePowerShellCredential to fetch an access token instead of the code that calls the CLIs
    • Note I intentionally did not use DefaultAzureCredential to preserve the current behavior, as it might require the user to specify a tenant ID under certain conditions
  • Support AzureWebJobsStorage__accountName in more scenarios:
    • Linux Consumption - fetches the storage account key using ARG+ARM and uses it to create the required SAS URI
    • Linux Elastic - combined code with Dedicated, as both support run from package
  • Remove old unused app.config (.NET Framework relic)

aelij avatar Jan 17 '24 15:01 aelij

I would be awesome if this could get merged & released. Making my storage account accessible via managed identity only led me to this PR, due to this not being merged yet I was forced to switch to WEBSITE_RUN_FROM_PACKAGE which seems to ignore requirements.txt which in turn leads to all kinds of other failures (see https://github.com/Azure/azure-functions-python-worker/issues/1262 for a fun example) and a lot of wasted time. I'd love to see this merged.

CrawX avatar Feb 25 '25 18:02 CrawX

@Azure/azure-functions-worker-owners @mattchenderson PTAL

aelij avatar Feb 26 '25 06:02 aelij

Closing as this branch has become stale.

aelij avatar Oct 30 '25 08:10 aelij