azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

Support dotnet-isolated runtime when deploying to KEDA

Open f1x3d opened this issue 2 years ago • 1 comments

Issue describing the changes in this PR

Resolves #2825

Apparently, the Kubernetes deployment part of the function tools was not updated to support dotnet-isolated worker runtime since it still looks for function.json files which are not being generated with the new runtime.

That being said, the functions metadata still gets created in the functions.metadata file which is essentially an array of objects with similar to function.json structure.

This PR adds support of dotnet-isolated runtime functions by reading the metadata from the new functions.metadata file.

To test this, create a new dotnet-isolated function project with at least one trigger and run func kubernetes deploy --name testname --registry testregistry --dry-run --dotnet-isolated The output should contain yamls for Deployment and ScaledObject with corresponding data.

Pull request checklist

  • [x] My changes do not require documentation changes
    • [ ] Otherwise: Documentation issue linked to PR
  • [ ] My changes do not need to be backported to a previous version
    • [x] Otherwise: Backport tracked by issue/PR #2556
  • [ ] I have added all required tests (Unit tests, E2E tests)

f1x3d avatar Mar 27 '22 17:03 f1x3d

Also, PR checklist mentions adding unit/e2e tests but the contributing guide says you can't run tests at this moment, so I would need some help with that

f1x3d avatar Mar 27 '22 17:03 f1x3d