azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

Could KeyVaultReferencesManager move to a non-functions library?

Open sopelt opened this issue 2 years ago • 3 comments

The KeyVaultReferencesManager looks like a great starting point for having a general purpose way of resolving key vault references outside of Azure App Service/Function Settings. If it could be refactored a bit (e.g. TokenCredential via constructor injection) it would be a great utility to have in a more common key vault library (e.g. here). An example use-case would be a dynamic, run-time configuration change that is not driven by app settings (e.g. loaded from a third party settings api, REST, DB ...).

sopelt avatar Mar 16 '22 12:03 sopelt

@sopelt Thank you for the suggestion, and this sounds like a great idea! However, the Functions team does not seem to be the appropriate one to make such a change. You may have better luck filing this as an issue on more Key Vault-adjacent repositories, such as the one you mentioned above. If you do so, feel free to mention me directly on the issue, as it seems there will be some work involved for this repository.

michaelpeng36 avatar Mar 16 '22 21:03 michaelpeng36

Is there a way to turn off the KeyVaultReferenceManager it missing with our app settings?

j03INTHECLOUD avatar Mar 18 '22 14:03 j03INTHECLOUD

@j03INTHECLOUD is this in reference to issue #2989 or a separate question? If it is the former, then the relevant change should be rolled back. If it is the latter, then this should be mentioned in a separate issue.

michaelpeng36 avatar Mar 22 '22 18:03 michaelpeng36