azure-functions-core-tools icon indicating copy to clipboard operation
azure-functions-core-tools copied to clipboard

Check for AzureWebJobsStorage fails when using identity-based connection

Open mattchenderson opened this issue 3 years ago • 7 comments

We are currently checking for AzureWebJobsStorage during func azure functionapp deploy:

https://github.com/Azure/azure-functions-core-tools/blob/6a070fb40308438c758ba8ab69399845bd698391/src/Azure.Functions.Cli/Actions/AzureActions/PublishFunctionAppAction.cs#L241-L244

Today this is just looking for an exact-match key, which fails when using an identity-based connection. In that model, there may be one or more keys prefixed with "AzureWebJobsStorage__". For example, the simplest configuration just has "AzureWebJobsStorage__accountName" which just takes the storage account name as a value. The Core Tools should treat these setups as equivalently valid and allow deployment to proceed.

Related to: Azure/Azure-Functions#2222

mattchenderson avatar Jul 28 '21 22:07 mattchenderson

@mattchenderson can you provide more details about the expected outcome here? design guidance would be helpful here.

apawast avatar Aug 17 '21 17:08 apawast

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

msftbot[bot] avatar Aug 21 '21 18:08 msftbot[bot]

reopening since this still needs to be fixed.

balag0 avatar Aug 24 '21 22:08 balag0

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

msftbot[bot] avatar Aug 29 '21 00:08 msftbot[bot]

That closure window is way too aggressive isn't it? This is still an issue. The guidance is to allow prefixing instead of exact name match.

mattchenderson avatar Oct 21 '21 01:10 mattchenderson

The auto-closure without notification to me is particularly irksome.

mattchenderson avatar Oct 21 '21 01:10 mattchenderson

@mattchenderson apologies, that label is tricky. @michaelpeng36 can you please help with this?

apawast avatar Oct 21 '21 17:10 apawast