azure-dev icon indicating copy to clipboard operation
azure-dev copied to clipboard

Published 20 hours ago • verified publisher icon Azure

Fix Playwright test fail in todo-nodejs-mongo

Open v-hongli1 opened this issue 3 years ago • 1 comments

Fixes issue https://github.com/Azure/azure-dev/issues/246

Change files: templates/todo/common/tests/todo.spec.ts Add setTimeOut is used to wait for the page data to full load.

@rajeshkamal5050 for notification.

v-hongli1 avatar Aug 22 '22 06:08 v-hongli1

I think it's better to pass { waitUntil: 'networkidle' } to the initial page.goto call as an option. So the code has now been fixed according to this idea.

v-hongli1 avatar Aug 23 '22 01:08 v-hongli1

pipeline is currently broken after this PR: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1814636&view=logs&j=9392ca66-1ee4-52af-022d-b22076a99114&t=6db148d5-c790-543c-3e98-57830bb8eafe&l=162

Change: image

image

@hongli750210 , any ideas?

vhvb1989 avatar Aug 29 '22 18:08 vhvb1989

@vhvb1989

  1. Does this bug only exist in branch issue #246, because this bug was not found in the merged branch main.
  2. Replace ： with : to fix the exception of parameter waitUntil. Can I still upload a new version after the code has been merged?

v-hongli1 avatar Aug 31 '22 01:08 v-hongli1

@hongli750210 additional syntax fix was made by @ellismg. Should be good now.

  • https://github.com/Azure/azure-dev/pull/546

rajeshkamal5050 avatar Aug 31 '22 04:08 rajeshkamal5050