azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

[AKS] az aks machine list/az aks machine show: Add zones to cli output

Open skuchipudi295 opened this issue 6 months ago • 11 comments

Related command az aks machine show az aks machine list

Description Adding zones to Machine api GA.

Testing Guide az aks machine list should show node name, IP info {name, ipv4, ipv6 addresses, zones(if zonal)} for all nodes in an agentpool. az aks machine show should show specific machine info {name, ipv4, ipv6 addresses, zones(if zonal)} in an agentpool

History Notes [AKS] BREAKING CHANGE: az aks machine list: Add zones to cli output [AKS] BREAKING CHANGE: az aks machine show: Add zones to cli output

This checklist is used to make sure that common guidelines for a pull request are followed.

skuchipudi295 avatar Jun 18 '25 18:06 skuchipudi295

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.9
️✔️acs
️✔️latest
️✔️3.12
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.9
️✔️ams
️✔️latest
️✔️3.12
️✔️3.9
️✔️apim
️✔️latest
️✔️3.12
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️aro
️✔️latest
️✔️3.12
️✔️3.9
️✔️backup
️✔️latest
️✔️3.12
️✔️3.9
️✔️batch
️✔️latest
️✔️3.12
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.9
️✔️billing
️✔️latest
️✔️3.12
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.9
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.9
️✔️config
️✔️latest
️✔️3.12
️✔️3.9
️✔️configure
️✔️latest
️✔️3.12
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.9
️✔️container
️✔️latest
️✔️3.12
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.9
️✔️core
️✔️latest
️✔️3.12
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.9
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.9
️✔️dls
️✔️latest
️✔️3.12
️✔️3.9
️✔️dms
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.9
️✔️find
️✔️latest
️✔️3.12
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.9
️✔️identity
️✔️latest
️✔️3.12
️✔️3.9
️✔️iot
️✔️latest
️✔️3.12
️✔️3.9
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.9
️✔️lab
️✔️latest
️✔️3.12
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️maps
️✔️latest
️✔️3.12
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.9
️✔️network
️✔️latest
️✔️3.12
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.9
️✔️profile
️✔️latest
️✔️3.12
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.9
️✔️redis
️✔️latest
️✔️3.12
️✔️3.9
️✔️relay
️✔️latest
️✔️3.12
️✔️3.9
️✔️resource
️✔️latest
️✔️3.12
️✔️3.9
️✔️role
️✔️latest
️✔️3.12
️✔️3.9
️✔️search
️✔️latest
️✔️3.12
️✔️3.9
️✔️security
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.9
️✔️sql
️✔️latest
️✔️3.12
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.9
️✔️storage
️✔️latest
️✔️3.12
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.9
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.9
️✔️util
️✔️latest
️✔️3.12
️✔️3.9
️✔️vm
️✔️latest
️✔️3.12
️✔️3.9

Hi @skuchipudi295, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

️✔️AzureCLI-BreakingChangeTest
️✔️Non Breaking Changes

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Jun 18 '25 18:06 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Jun 18 '25 18:06 github-actions[bot]

/azp run

FumingZhang avatar Jun 18 '25 23:06 FumingZhang

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 18 '25 23:06 azure-pipelines[bot]

/azp run

skuchipudi295 avatar Jun 19 '25 20:06 skuchipudi295

Commenter does not have sufficient privileges for PR 31668 in repo Azure/azure-cli

azure-pipelines[bot] avatar Jun 19 '25 20:06 azure-pipelines[bot]

/azp run

yonzhan avatar Jun 19 '25 22:06 yonzhan

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 19 '25 22:06 azure-pipelines[bot]

/azp run

FumingZhang avatar Jun 23 '25 01:06 FumingZhang

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 23 '25 01:06 azure-pipelines[bot]

please fix style issue

src/azure-cli/azure/cli/command_modules/acs/_format.py:64:42: C0303: Trailing whitespace (trailing-whitespace) src/azure-cli/azure/cli/command_modules/acs/_format.py:67:0: C0301: Line too long (135/120) (line-too-long)

FumingZhang avatar Jun 24 '25 04:06 FumingZhang

/azp run

FumingZhang avatar Jun 24 '25 04:06 FumingZhang

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 24 '25 04:06 azure-pipelines[bot]

live test

failed with following error

      'machine_name': machine_name,
                        ^^^^^^^^^^^^
    })

E NameError: name 'machine_name' is not defined

azure-cli/src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py:2209: NameError

https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=128208339&view=logs&j=b162b355-d59d-5864-ce0f-0a70f12dd28b&t=dc59ccd1-231f-538b-777f-33a592c7ca57&l=2635

FumingZhang avatar Jun 24 '25 06:06 FumingZhang

/azp run

FumingZhang avatar Jun 26 '25 03:06 FumingZhang

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 26 '25 03:06 azure-pipelines[bot]

I suppose this is not a breaking change, please remove BREAKING CHANGE from notes.

History Notes [AKS] BREAKING CHANGE: az aks machine list: Add zones to cli output [AKS] BREAKING CHANGE: az aks machine show: Add zones to cli output

FumingZhang avatar Jun 26 '25 04:06 FumingZhang

Re-queued live test

FumingZhang avatar Jun 26 '25 04:06 FumingZhang

Please note that there's a code freeze until the latest version of azure-cli is officially released

FumingZhang avatar Jun 26 '25 04:06 FumingZhang

/azp run

yanzhudd avatar Jul 02 '25 06:07 yanzhudd

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 02 '25 06:07 azure-pipelines[bot]

optimized the history notes: image

yanzhudd avatar Jul 03 '25 01:07 yanzhudd