azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

[AKS] az aks create/update: Add new parameter --enable-ai-toolchain-operator to enable Kaito addon

Open helayoty opened this issue 7 months ago • 6 comments

Related command az aks create az aks update

Description Add --enable-ai-toolchain-operator and --disable-ai-toolchain-operator to az aks cli.

Testing Guide

  • az aks create <cluster_name> -g <resource_group_name> --enable-ai-toolchain-operator
  • az aks update <cluster_name> -g <resource_group_name> --enable-ai-toolchain-operator
  • az aks create <cluster_name> -g <resource_group_name> --disable-ai-toolchain-operator

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change [Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

helayoty avatar May 16 '25 04:05 helayoty

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.9
️✔️acs
️✔️latest
️✔️3.12
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.9
️✔️ams
️✔️latest
️✔️3.12
️✔️3.9
️✔️apim
️✔️latest
️✔️3.12
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️aro
️✔️latest
️✔️3.12
️✔️3.9
️✔️backup
️✔️latest
️✔️3.12
️✔️3.9
️✔️batch
️✔️latest
️✔️3.12
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.9
️✔️billing
️✔️latest
️✔️3.12
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.9
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.9
️✔️config
️✔️latest
️✔️3.12
️✔️3.9
️✔️configure
️✔️latest
️✔️3.12
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.9
️✔️container
️✔️latest
️✔️3.12
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.9
️✔️core
️✔️latest
️✔️3.12
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.9
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.9
️✔️dls
️✔️latest
️✔️3.12
️✔️3.9
️✔️dms
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.9
️✔️find
️✔️latest
️✔️3.12
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.9
️✔️identity
️✔️latest
️✔️3.12
️✔️3.9
️✔️iot
️✔️latest
️✔️3.12
️✔️3.9
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.9
️✔️lab
️✔️latest
️✔️3.12
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️maps
️✔️latest
️✔️3.12
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.9
️✔️network
️✔️latest
️✔️3.12
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.9
️✔️profile
️✔️latest
️✔️3.12
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.9
️✔️redis
️✔️latest
️✔️3.12
️✔️3.9
️✔️relay
️✔️latest
️✔️3.12
️✔️3.9
️✔️resource
️✔️latest
️✔️3.12
️✔️3.9
️✔️role
️✔️latest
️✔️3.12
️✔️3.9
️✔️search
️✔️latest
️✔️3.12
️✔️3.9
️✔️security
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.9
️✔️sql
️✔️latest
️✔️3.12
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.9
️✔️storage
️✔️latest
️✔️3.12
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.9
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.9
️✔️util
️✔️latest
️✔️3.12
️✔️3.9
️✔️vm
️✔️latest
️✔️3.12
️✔️3.9

⚠️AzureCLI-BreakingChangeTest
⚠️acs
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_ai_toolchain_operator
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_ai_toolchain_operator
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_ai_toolchain_operator

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar May 16 '25 04:05 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar May 16 '25 04:05 github-actions[bot]

Depends on SDK generated based on 2025-05-01

FumingZhang avatar May 16 '25 05:05 FumingZhang

updated milestone to https://github.com/Azure/azure-cli/milestone/157

FumingZhang avatar May 23 '25 06:05 FumingZhang

Hi @FumingZhang is this PR ready to review and merge?

yanzhudd avatar Jun 23 '25 06:06 yanzhudd

/azp run

yanzhudd avatar Jun 23 '25 06:06 yanzhudd

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 23 '25 06:06 azure-pipelines[bot]

Queued live test to validate the change.

  • test_aks_create_with_enable_ai_toolchain_operator
  • test_aks_update_with_enable_ai_toolchain_operator

Re-queued live test after rebasing the branch from dev to include the SDK version update. https://github.com/FumingZhang/azure-cli/tree/fuming/helayoty/kaito

FumingZhang avatar Jun 23 '25 06:06 FumingZhang

Queued live test to validate the change.

  • test_aks_create_with_enable_ai_toolchain_operator
  • test_aks_update_with_enable_ai_toolchain_operator

Re-queued live test after rebasing the branch from dev to include the SDK version update. https://github.com/FumingZhang/azure-cli/tree/fuming/helayoty/kaito

failed with error

E AttributeError: 'ManagedCluster' object has no attribute 'ai_toolchain_operator_profile'

https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=128092330&view=logs&j=b162b355-d59d-5864-ce0f-0a70f12dd28b&t=dc59ccd1-231f-538b-777f-33a592c7ca57&l=2702

FumingZhang avatar Jun 23 '25 06:06 FumingZhang

please fix the testing issues.

yanzhudd avatar Jun 23 '25 06:06 yanzhudd

Please note that Azure CLI will have a code freeze on 06/24/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve the CI issue ASAP, otherwise it has to be postponed to next sprint (08-05).

zhoxing-ms avatar Jun 23 '25 09:06 zhoxing-ms

/azp run

yanzhudd avatar Jun 24 '25 00:06 yanzhudd

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 24 '25 00:06 azure-pipelines[bot]

Depends on SDK generated based on 2025-05-01

the sdk is not ready yet, moving to next milestone https://github.com/Azure/azure-cli/milestone/158

FumingZhang avatar Jun 24 '25 04:06 FumingZhang

Queued live test to validate the change after rebasing.

  • test_aks_create_with_enable_ai_toolchain_operator
  • test_aks_update_with_enable_ai_toolchain_operator

Result: Passed

helayoty avatar Jul 17 '25 20:07 helayoty

Commenter does not have sufficient privileges for PR 31485 in repo Azure/azure-cli

azure-pipelines[bot] avatar Jul 17 '25 20:07 azure-pipelines[bot]

/azp run

yonzhan avatar Jul 17 '25 23:07 yonzhan

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 17 '25 23:07 azure-pipelines[bot]

/azp run

FumingZhang avatar Jul 18 '25 01:07 FumingZhang

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 18 '25 01:07 azure-pipelines[bot]

Queued live test to validate the change after addressing the feedback rebasing.

helayoty avatar Jul 18 '25 20:07 helayoty

/azp run

FumingZhang avatar Jul 21 '25 00:07 FumingZhang

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 21 '25 00:07 azure-pipelines[bot]

Newly added test cases failed in replay mode https://dev.azure.com/azclitools/public/_build/results?buildId=261975&view=logs&j=c4905e22-e505-5bfe-aa0a-49d3f9325fa2&t=cf247c3b-aad8-52b9-12ca-ceb3e5942fcf&l=4222

FAILED src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_create_with_enable_ai_toolchain_operator FAILED src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_update_with_enable_ai_toolchain_operator

Newly queued live test will help generate the correct recording files you'll need. Please download them from pipeline artifacts and commit them accordingly.

FumingZhang avatar Jul 21 '25 04:07 FumingZhang

Newly added test cases failed in replay mode https://dev.azure.com/azclitools/public/_build/results?buildId=261975&view=logs&j=c4905e22-e505-5bfe-aa0a-49d3f9325fa2&t=cf247c3b-aad8-52b9-12ca-ceb3e5942fcf&l=4222

FAILED src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_create_with_enable_ai_toolchain_operator FAILED src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_update_with_enable_ai_toolchain_operator

Newly queued live test will help generate the correct recording files you'll need. Please download them from pipeline artifacts and commit them accordingly.

Addressed and replaced. However I didn't see the failure in the latest running pipeline you mentioned.

Latest live test passed.

helayoty avatar Jul 21 '25 17:07 helayoty

/azp run

FumingZhang avatar Jul 21 '25 23:07 FumingZhang

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 21 '25 23:07 azure-pipelines[bot]