azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

[App Service] Fix #28858: `az webapp config container set`: Add support for managed identity pull from ACR

Open madsd opened this issue 9 months ago • 19 comments

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change [Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

madsd avatar Feb 20 '25 10:02 madsd

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.13
️✔️acs
️✔️latest
️✔️3.12
️✔️3.13
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.13
️✔️ams
️✔️latest
️✔️3.12
️✔️3.13
️✔️apim
️✔️latest
️✔️3.12
️✔️3.13
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.13
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️aro
️✔️latest
️✔️3.12
️✔️3.13
️✔️backup
️✔️latest
️✔️3.12
️✔️3.13
️✔️batch
️✔️latest
️✔️3.12
️✔️3.13
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.13
️✔️billing
️✔️latest
️✔️3.12
️✔️3.13
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.13
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.13
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.13
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.13
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.13
️✔️config
️✔️latest
️✔️3.12
️✔️3.13
️✔️configure
️✔️latest
️✔️3.12
️✔️3.13
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.13
️✔️container
️✔️latest
️✔️3.12
️✔️3.13
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.13
️✔️core
️✔️latest
️✔️3.12
️✔️3.13
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.13
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.13
️✔️dls
️✔️latest
️✔️3.12
️✔️3.13
️✔️dms
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.13
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.13
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.13
️✔️find
️✔️latest
️✔️3.12
️✔️3.13
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.13
️✔️identity
️✔️latest
️✔️3.12
️✔️3.13
️✔️iot
️✔️latest
️✔️3.12
️✔️3.13
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.13
️✔️lab
️✔️latest
️✔️3.12
️✔️3.13
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.13
️✔️maps
️✔️latest
️✔️3.12
️✔️3.13
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.13
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.13
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.13
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.13
️✔️network
️✔️latest
️✔️3.12
️✔️3.13
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.13
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.13
️✔️profile
️✔️latest
️✔️3.12
️✔️3.13
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.13
️✔️redis
️✔️latest
️✔️3.12
️✔️3.13
️✔️relay
️✔️latest
️✔️3.12
️✔️3.13
️✔️resource
️✔️latest
️✔️3.12
️✔️3.13
️✔️role
️✔️latest
️✔️3.12
️✔️3.13
️✔️search
️✔️latest
️✔️3.12
️✔️3.13
️✔️security
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.13
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.13
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.13
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.13
️✔️sql
️✔️latest
️✔️3.12
️✔️3.13
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.13
️✔️storage
️✔️latest
️✔️3.12
️✔️3.13
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.13
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.13
️✔️util
️✔️latest
️✔️3.12
️✔️3.13
️✔️vm
️✔️latest
️✔️3.12
️✔️3.13

Hi @madsd, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

⚠️AzureCLI-BreakingChangeTest
⚠️appservice
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd webapp config container set cmd webapp config container set added parameter acr_identity
⚠️ 1006 - ParaAdd webapp config container set cmd webapp config container set added parameter acr_use_identity
⚠️ 1006 - ParaAdd webapp config container set cmd webapp config container set added parameter assign_identities
⚠️ 1006 - ParaAdd webapp config container set cmd webapp config container set added parameter role
⚠️ 1006 - ParaAdd webapp config container set cmd webapp config container set added parameter scope

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Feb 20 '25 10:02 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Feb 20 '25 10:02 github-actions[bot]

Fixes: #28858

seligj95 avatar Feb 20 '25 15:02 seligj95

For the managed assigned identity related parameters, please refer this unified specification document to design them managed_identity_command_guideline.md

zhoxing-ms avatar Mar 24 '25 11:03 zhoxing-ms

For the managed assigned identity related parameters, please refer this unified specification document to design them managed_identity_command_guideline.md

@zhoxing-ms is it the --assign-identities property that you want to split in two and rename to --mi-system-assigned and --mi-user-assigned?

madsd avatar Mar 24 '25 12:03 madsd

@madsd If there is a similar scenario design in the app service before, it can be implemented according to the previous design and migrated uniformly in the future. Otherwise, it is recommended to design commands according to the specifications in the document

zhoxing-ms avatar Mar 24 '25 15:03 zhoxing-ms

@zhoxing-ms Yes, I did chose this implementation to match existing patterns in the az webapp commands so I think we should keep the current design and do a uniform migration in the future. Thanks

madsd avatar Mar 25 '25 09:03 madsd

please note that Azure CLI will have a code freeze on 04/21/2025 07:00 UTC for the upcoming release. Please address the comments ASAP, otherwise it has to be postponed to next sprint (05-19).

yanzhudd avatar Apr 21 '25 03:04 yanzhudd

@yanzhudd The comments were addressed. We agreed to use the existing pattern for managed identity used by other App Service command and do a bulk migration when it makes sense. So I would think the PR is ready to merge.

madsd avatar Apr 21 '25 16:04 madsd

@madsd Could you please resolve these CI issues?

zhoxing-ms avatar May 12 '25 09:05 zhoxing-ms

please note that Azure CLI will have a code freeze on 05/13/2025 07:00 UTC for the upcoming release. Please address the comments ASAP, otherwise it has to be postponed to next sprint (06-03).

zhoxing-ms avatar May 12 '25 09:05 zhoxing-ms

@madsd please note that Azure CLI will have a code freeze on 05/27/2025 07:00 UTC for the upcoming release. Please address these CI issues ASAP, otherwise it has to be postponed to next sprint (07-01).

zhoxing-ms avatar May 26 '25 08:05 zhoxing-ms

Removed flaky test - there are already existing tests verifying managed identity and container image pull.

madsd avatar Jun 11 '25 11:06 madsd

/azp run

yanzhudd avatar Jun 12 '25 01:06 yanzhudd

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 12 '25 01:06 azure-pipelines[bot]

could you please add some tests for the new added parameters?

yanzhudd avatar Jun 12 '25 01:06 yanzhudd

@madsd Could you please resolve these conflicts and comments?

zhoxing-ms avatar Jun 23 '25 07:06 zhoxing-ms

please note that Azure CLI will have a code freeze on 06/24/2025 07:00 UTC for the upcoming release. Please address these CI issues ASAP, otherwise it has to be postponed to next sprint (08-05).

zhoxing-ms avatar Jun 23 '25 07:06 zhoxing-ms

@madsd Any update?

zhoxing-ms avatar Jul 28 '25 09:07 zhoxing-ms

Please note that Azure CLI will freeze the code on 07/29/2025 07:00 UTC for the upcoming release. If you want to catch this release train, please resolve these comments ASAP, otherwise this PR has to be postponed to next sprint.

zhoxing-ms avatar Jul 28 '25 09:07 zhoxing-ms

/azp run

yanzhudd avatar Aug 25 '25 12:08 yanzhudd

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Aug 25 '25 12:08 azure-pipelines[bot]

please note that the code completion date for the upcoming release is 08/26/2025 at 07:00 UTC. If you want to catch this release train, please address the comments ASAP, otherwise it has to be postponed to next sprint (10/14).

yanzhudd avatar Aug 25 '25 12:08 yanzhudd