azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

{Service Fabric} Add securityType and SecureBootEnabled properties to Nodetype

Open mwesigwaguma opened this issue 1 year ago • 6 comments

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change [Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

mwesigwaguma avatar May 20 '24 15:05 mwesigwaguma

❌AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.11
️✔️3.9
️✔️ams
️✔️latest
️✔️3.11
️✔️3.9
️✔️apim
️✔️latest
️✔️3.11
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.11
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️aro
️✔️latest
️✔️3.11
️✔️3.9
️✔️backup
️✔️latest
️✔️3.11
️✔️3.9
️✔️batch
️✔️latest
️✔️3.11
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.11
️✔️3.9
️✔️billing
️✔️latest
️✔️3.11
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.11
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.11
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.11
️✔️3.9
️✔️config
️✔️latest
️✔️3.11
️✔️3.9
️✔️configure
️✔️latest
️✔️3.11
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.11
️✔️3.9
️✔️container
️✔️latest
️✔️3.11
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.11
️✔️3.9
❌core
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
❌latest
❌3.11
Type Test Case Error Message Line
Failed test_help_loads The error message is too long, please check the pipeline log for details. azure/cli/core/tests/test_help.py:120
❌3.9
Type Test Case Error Message Line
Failed test_help_loads The error message is too long, please check the pipeline log for details. azure/cli/core/tests/test_help.py:120
️✔️cosmosdb
️✔️latest
️✔️3.11
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️dla
️✔️latest
️✔️3.11
️✔️3.9
️✔️dls
️✔️latest
️✔️3.11
️✔️3.9
️✔️dms
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.11
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.11
️✔️3.9
️✔️find
️✔️latest
️✔️3.11
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.11
️✔️3.9
️✔️identity
️✔️latest
️✔️3.11
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️kusto
️✔️latest
️✔️3.11
️✔️3.9
️✔️lab
️✔️latest
️✔️3.11
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️maps
️✔️latest
️✔️3.11
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.11
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.11
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.11
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.11
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.11
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.11
️✔️3.9
️✔️profile
️✔️latest
️✔️3.11
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.11
️✔️3.9
️✔️redis
️✔️latest
️✔️3.11
️✔️3.9
️✔️relay
️✔️latest
️✔️3.11
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️role
️✔️latest
️✔️3.11
️✔️3.9
️✔️search
️✔️latest
️✔️3.11
️✔️3.9
️✔️security
️✔️latest
️✔️3.11
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.11
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.11
️✔️3.9
❌servicefabric
❌latest
❌3.11
Type Test Case Error Message Line
Failed test_create_cluster_with_separate_kv The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_cluster.py:17
Failed test_update_settings_and_reliability The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_cluster.py:31
Failed test_managed_app_type The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:15
Failed test_managed_app_type_version The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:60
Failed test_managed_application The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:106
Failed test_managed_service The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:174
Failed test_basic_cluster The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:17
Failed test_cert_and_ext The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:211
Failed test_network_security_rule The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:48
Failed test_node_type_operation The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:116
Failed test_secureboot_security_type_test The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:180
❌3.9
Type Test Case Error Message Line
Failed test_create_cluster_with_separate_kv The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_cluster.py:17
Failed test_update_settings_and_reliability The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_cluster.py:31
Failed test_managed_app_type The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:15
Failed test_managed_app_type_version The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:60
Failed test_managed_application The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:106
Failed test_managed_service The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_application.py:174
Failed test_basic_cluster The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:17
Failed test_cert_and_ext The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:211
Failed test_network_security_rule The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:48
Failed test_node_type_operation The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:116
Failed test_secureboot_security_type_test The error message is too long, please check the pipeline log for details. azure/cli/command_modules/servicefabric/tests/latest/test_sf_managed_cluster.py:180
️✔️signalr
️✔️latest
️✔️3.11
️✔️3.9
️✔️sql
️✔️latest
️✔️3.11
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.11
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.11
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️util
️✔️latest
️✔️3.11
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9

️✔️AzureCLI-BreakingChangeTest
️✔️Non Breaking Changes

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar May 20 '24 15:05 yonzhan

Please resolve the CI issues. Please note that we will freeze the code on 07/02/2024 10:00 UTC for the upcoming release. If you want to catch the release train, please resolve the comments as soon as possible, otherwise we have to postpone this PR to the next sprint (08-06).

yanzhudd avatar Jun 24 '24 06:06 yanzhudd

/azp run

yanzhudd avatar Jun 24 '24 06:06 yanzhudd

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jun 24 '24 06:06 azure-pipelines[bot]

@mwesigwaguma Since we haven't received a response to this PR for a long time, I will put it in the backlog first. After you have resolved its comments, we will consider adding it to the release milestone

zhoxing-ms avatar Jul 29 '24 07:07 zhoxing-ms