[ACR] BREAKING CHANGE: connected-registry: commands update

[rosanch]

Related command az acr connected-registry create/update/install

Description Minor updates on ACR connected registry commands:

• install sub-group and commands are removed
• create: mode default value change to readOnly
• create: if data endpoint disable ask for enabling it instead of throwing an error.
• update: change command type to use generic_update_command instead

Testing Guide

1. Create connected-registry in an ACR without data-endpoint enabled 1.1 respond no 1.2 try again respond yes
2. create another connected-registry in the same ACR
3. update any connected-registry

History Notes

[ACR] BREAKING CHANGE: az acr connected-registry install: Group and sub-commands removed [ACR] BREAKING CHANGE: az acr connected-registry create: Mode default value change from ReadWrite to ReadOnly [ACR] az acr connected-registry create: If data-endpoint disabled ask for confirmation to enable it instead of throwing an error

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• [x] The PR title and description has followed the guideline in Submitting Pull Requests.

• [x] I adhere to the Command Guidelines.

• [x] I adhere to the Error Handling Guidelines.

[azure-client-tools-bot-prd[bot]]

❌AzureCLI-FullTest

❌acr

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

❌latest

❌3.11

Type	Test Case	Error Message	Line
Failed	test_acr_connectedregistry	The error message is too long, please check the pipeline log for details.	azure/cli/command_modules/acr/tests/latest/test_acr_connectedregistry_commands.py:10

❌3.9

Type	Test Case	Error Message	Line
Failed	test_acr_connectedregistry	The error message is too long, please check the pipeline log for details.	azure/cli/command_modules/acr/tests/latest/test_acr_connectedregistry_commands.py:10

️✔️acs

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️advisor

️✔️latest

️✔️3.11

️✔️3.9

️✔️ams

️✔️latest

️✔️3.11

️✔️3.9

️✔️apim

️✔️latest

️✔️3.11

️✔️3.9

️✔️appconfig

️✔️latest

️✔️3.11

️✔️3.9

️✔️appservice

️✔️latest

️✔️3.11

️✔️3.9

️✔️aro

️✔️latest

️✔️3.11

️✔️3.9

️✔️backup

️✔️latest

️✔️3.11

️✔️3.9

️✔️batch

️✔️latest

️✔️3.11

️✔️3.9

️✔️batchai

️✔️latest

️✔️3.11

️✔️3.9

️✔️billing

️✔️latest

️✔️3.11

️✔️3.9

️✔️botservice

️✔️latest

️✔️3.11

️✔️3.9

️✔️cdn

️✔️latest

️✔️3.11

️✔️3.9

️✔️cloud

️✔️latest

️✔️3.11

️✔️3.9

️✔️cognitiveservices

️✔️latest

️✔️3.11

️✔️3.9

️✔️config

️✔️latest

️✔️3.11

️✔️3.9

️✔️configure

️✔️latest

️✔️3.11

️✔️3.9

️✔️consumption

️✔️latest

️✔️3.11

️✔️3.9

️✔️container

️✔️latest

️✔️3.11

️✔️3.9

️✔️containerapp

️✔️latest

️✔️3.11

️✔️3.9

️✔️core

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️cosmosdb

️✔️latest

️✔️3.11

️✔️3.9

️✔️databoxedge

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️dla

️✔️latest

️✔️3.11

️✔️3.9

️✔️dls

️✔️latest

️✔️3.11

️✔️3.9

️✔️dms

️✔️latest

️✔️3.11

️✔️3.9

️✔️eventgrid

️✔️latest

️✔️3.11

️✔️3.9

️✔️eventhubs

️✔️latest

️✔️3.11

️✔️3.9

️✔️feedback

️✔️latest

️✔️3.11

️✔️3.9

️✔️find

️✔️latest

️✔️3.11

️✔️3.9

️✔️hdinsight

️✔️latest

️✔️3.11

️✔️3.9

️✔️identity

️✔️latest

️✔️3.11

️✔️3.9

️✔️iot

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️keyvault

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️kusto

️✔️latest

️✔️3.11

️✔️3.9

️✔️lab

️✔️latest

️✔️3.11

️✔️3.9

️✔️managedservices

️✔️latest

️✔️3.11

️✔️3.9

️✔️maps

️✔️latest

️✔️3.11

️✔️3.9

️✔️marketplaceordering

️✔️latest

️✔️3.11

️✔️3.9

️✔️monitor

️✔️latest

️✔️3.11

️✔️3.9

️✔️mysql

️✔️latest

️✔️3.11

️✔️3.9

️✔️netappfiles

️✔️latest

️✔️3.11

️✔️3.9

️✔️network

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️policyinsights

️✔️latest

️✔️3.11

️✔️3.9

️✔️privatedns

️✔️latest

️✔️3.11

️✔️3.9

️✔️profile

️✔️latest

️✔️3.11

️✔️3.9

️✔️rdbms

️✔️latest

️✔️3.11

️✔️3.9

️✔️redis

️✔️latest

️✔️3.11

️✔️3.9

️✔️relay

️✔️latest

️✔️3.11

️✔️3.9

️✔️resource

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️role

️✔️latest

️✔️3.11

️✔️3.9

️✔️search

️✔️latest

️✔️3.11

️✔️3.9

️✔️security

️✔️latest

️✔️3.11

️✔️3.9

️✔️servicebus

️✔️latest

️✔️3.11

️✔️3.9

️✔️serviceconnector

️✔️latest

️✔️3.11

️✔️3.9

️✔️servicefabric

️✔️latest

️✔️3.11

️✔️3.9

️✔️signalr

️✔️latest

️✔️3.11

️✔️3.9

️✔️sql

️✔️latest

️✔️3.11

️✔️3.9

️✔️sqlvm

️✔️latest

️✔️3.11

️✔️3.9

️✔️storage

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️synapse

️✔️latest

️✔️3.11

️✔️3.9

️✔️telemetry

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️util

️✔️latest

️✔️3.11

️✔️3.9

️✔️vm

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

[azure-client-tools-bot-prd[bot]]

❌AzureCLI-BreakingChangeTest

❌acr

rule	cmd_name	rule_message	suggest_message
❌ 1010 - ParaPropUpdate	acr connected-registry create	cmd acr connected-registry create update parameter mode: updated property default from ReadWrite to ReadOnly	please change property default from ReadOnly to ReadWrite for parameter mode of cmd acr connected-registry create
❌ 1012 - SubgroupRemove	acr connected-registry install	sub group acr connected-registry install removed	please confirm sub group acr connected-registry install removed
❌ 1002 - CmdRemove	acr connected-registry repo	cmd acr connected-registry repo removed	please confirm cmd acr connected-registry repo removed
⚠️ 1006 - ParaAdd	acr connected-registry create	cmd acr connected-registry create added parameter yes
⚠️ 1006 - ParaAdd	acr connected-registry update	cmd acr connected-registry update added parameter force_string
⚠️ 1006 - ParaAdd	acr connected-registry update	cmd acr connected-registry update added parameter properties_to_add
⚠️ 1006 - ParaAdd	acr connected-registry update	cmd acr connected-registry update added parameter properties_to_remove
⚠️ 1006 - ParaAdd	acr connected-registry update	cmd acr connected-registry update added parameter properties_to_set

[yonzhan]

ACR

[rosanch]

@zhoxing-ms I see coverage failing saying we don't have tests for acr connected-registry update but we do. Can you please take a look?

[rosanch]

@zhoxing-ms any updates regarding the testing issue?? cc: @jsntcy @yanzhudd

[zhoxing-ms]

@rosanch Please resolve these CI issues. Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 05-21)

[rosanch]

@zhoxing-ms The issue states that we do not have a az connected-registry update test. However, we do. I believe the testing must be confused because we changed the command from using the custom_command to the generic_update_command to follow CLI best practices. However, the PR testing is saying we do not have any tests in place for the command.

[huanwu]

@zhoxing-ms , this is the test for az acr connected-registry update https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_connectedregistry_commands.py#L101 for

[zhoxing-ms]

@rosanch @huanwu Actually, I saw other errors in the CI pipeline pipeline link . Please resolve these CI errors first

[zhoxing-ms]

[ACR] BREAKING CHANGE: az acr connected-registry install: Group and sub-commands removed [ACR] BREAKING CHANGE: az acr connected-registry create: Mode default value change from ReadWrite to ReadOnly

Additionally, as this PR includes some breaking changes, it can usually only be released in our breaking change window (Ignite or Build Sprint). Therefore, I suggest postponing its release to the next sprint as the next sprint is a breaking change window for Build (05-21)

[huanwu]

@rosanch @huanwu Actually, I saw other errors in the CI pipeline pipeline link . Please resolve these CI errors first

@zhoxing-ms, the failure seems unrelated to the change. Can we rerun the tests?

[zhoxing-ms]

@huanwu @rosanch The reason for these CI issues is that the current yaml file has one less GET request than the code logic, which may be due to a code logic change without re-recording the yaml file. Could you help re-record these failed tests test_acr_connectedregistry in live mode?

[zhoxing-ms]

@rosanch @huanwu By the way, please add some new test cases for this PR change

[zhoxing-ms]

@rosanch Could you please resolve this conflict file?

[zhoxing-ms]

Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 07-02)

[yanzhudd]

please resolve CI issues

[zhoxing-ms]

@rosanch Please resolve these conflicts and CI issues

[zhoxing-ms]

https://github.com/Azure/azure-cli/pull/28682#discussion_r1575740558 Please address this comment

[zhoxing-ms]

@rosanch Since we haven't received a response to this PR for a long time, I will put it in the backlog first. After you have resolved its comments and conflicts, we will consider adding it to the release milestone