[Service Fabric] `az sf managed-node-type node reimage`: Add new parameter `--update-type` to specify the way the operation will be performed

[mwesigwaguma]

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change [Component Name 2] az command b: Add some customer-facing feature

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• [ ] The PR title and description has followed the guideline in Submitting Pull Requests.

• [ ] I adhere to the Command Guidelines.

• [ ] I adhere to the Error Handling Guidelines.

[azure-client-tools-bot-prd[bot]]

️✔️AzureCLI-FullTest

️✔️acr

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️acs

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️advisor

️✔️latest

️✔️3.11

️✔️3.9

️✔️ams

️✔️latest

️✔️3.11

️✔️3.9

️✔️apim

️✔️latest

️✔️3.11

️✔️3.9

️✔️appconfig

️✔️latest

️✔️3.11

️✔️3.9

️✔️appservice

️✔️latest

️✔️3.11

️✔️3.9

️✔️aro

️✔️latest

️✔️3.11

️✔️3.9

️✔️backup

️✔️latest

️✔️3.11

️✔️3.9

️✔️batch

️✔️latest

️✔️3.11

️✔️3.9

️✔️batchai

️✔️latest

️✔️3.11

️✔️3.9

️✔️billing

️✔️latest

️✔️3.11

️✔️3.9

️✔️botservice

️✔️latest

️✔️3.11

️✔️3.9

️✔️cdn

️✔️latest

️✔️3.11

️✔️3.9

️✔️cloud

️✔️latest

️✔️3.11

️✔️3.9

️✔️cognitiveservices

️✔️latest

️✔️3.11

️✔️3.9

️✔️compute_recommender

️✔️latest

️✔️3.11

️✔️3.9

️✔️config

️✔️latest

️✔️3.11

️✔️3.9

️✔️configure

️✔️latest

️✔️3.11

️✔️3.9

️✔️consumption

️✔️latest

️✔️3.11

️✔️3.9

️✔️container

️✔️latest

️✔️3.11

️✔️3.9

️✔️containerapp

️✔️latest

️✔️3.11

️✔️3.9

️✔️core

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️cosmosdb

️✔️latest

️✔️3.11

️✔️3.9

️✔️databoxedge

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️dla

️✔️latest

️✔️3.11

️✔️3.9

️✔️dls

️✔️latest

️✔️3.11

️✔️3.9

️✔️dms

️✔️latest

️✔️3.11

️✔️3.9

️✔️eventgrid

️✔️latest

️✔️3.11

️✔️3.9

️✔️eventhubs

️✔️latest

️✔️3.11

️✔️3.9

️✔️feedback

️✔️latest

️✔️3.11

️✔️3.9

️✔️find

️✔️latest

️✔️3.11

️✔️3.9

️✔️hdinsight

️✔️latest

️✔️3.11

️✔️3.9

️✔️identity

️✔️latest

️✔️3.11

️✔️3.9

️✔️iot

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️keyvault

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️kusto

️✔️latest

️✔️3.11

️✔️3.9

️✔️lab

️✔️latest

️✔️3.11

️✔️3.9

️✔️managedservices

️✔️latest

️✔️3.11

️✔️3.9

️✔️maps

️✔️latest

️✔️3.11

️✔️3.9

️✔️marketplaceordering

️✔️latest

️✔️3.11

️✔️3.9

️✔️monitor

️✔️latest

️✔️3.11

️✔️3.9

️✔️mysql

️✔️latest

️✔️3.11

️✔️3.9

️✔️netappfiles

️✔️latest

️✔️3.11

️✔️3.9

️✔️network

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️policyinsights

️✔️latest

️✔️3.11

️✔️3.9

️✔️privatedns

️✔️latest

️✔️3.11

️✔️3.9

️✔️profile

️✔️latest

️✔️3.11

️✔️3.9

️✔️rdbms

️✔️latest

️✔️3.11

️✔️3.9

️✔️redis

️✔️latest

️✔️3.11

️✔️3.9

️✔️relay

️✔️latest

️✔️3.11

️✔️3.9

️✔️resource

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️role

️✔️latest

️✔️3.11

️✔️3.9

️✔️search

️✔️latest

️✔️3.11

️✔️3.9

️✔️security

️✔️latest

️✔️3.11

️✔️3.9

️✔️servicebus

️✔️latest

️✔️3.11

️✔️3.9

️✔️serviceconnector

️✔️latest

️✔️3.11

️✔️3.9

️✔️servicefabric

️✔️latest

️✔️3.11

️✔️3.9

️✔️signalr

️✔️latest

️✔️3.11

️✔️3.9

️✔️sql

️✔️latest

️✔️3.11

️✔️3.9

️✔️sqlvm

️✔️latest

️✔️3.11

️✔️3.9

️✔️storage

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️synapse

️✔️latest

️✔️3.11

️✔️3.9

️✔️telemetry

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

️✔️util

️✔️latest

️✔️3.11

️✔️3.9

️✔️vm

️✔️2018-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2019-03-01-hybrid

️✔️3.11

️✔️3.9

️✔️2020-09-01-hybrid

️✔️3.11

️✔️3.9

️✔️latest

️✔️3.11

️✔️3.9

[azure-client-tools-bot-prd[bot]]

⚠️AzureCLI-BreakingChangeTest

⚠️servicefabric

rule	cmd_name	rule_message	suggest_message
⚠️ 1006 - ParaAdd	sf managed-node-type node reimage	cmd sf managed-node-type node reimage added parameter update_type
⚠️ 1009 - ParaPropRemove	sf managed-node-type node reimage	cmd sf managed-node-type node reimage update parameter node_name: removed property required=True
⚠️ 1006 - ParaAdd	sf managed-node-type node restart	cmd sf managed-node-type node restart added parameter update_type
⚠️ 1009 - ParaPropRemove	sf managed-node-type node restart	cmd sf managed-node-type node restart update parameter node_name: removed property required=True

[yonzhan]

Service Fabric

[yanzhudd]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 3 pipeline(s).

[yanzhudd]

Since the Azure CLI team only takes responsibility of code style and specification but not business logic, it would be best to have it approved by @a-santamaria firstly and then reviewed by the Azure CLI team. Please note that CLI will have a code freeze for this release train on 04/23/2024 10:00 UTC. If you want to catch this release train, please have it approved as soon as possible, otherwise it has be be postponed to next sprint.

[zhoxing-ms]

Since the Azure CLI team only takes responsibility of code style and specification but not business logic, it would be best to have it approved by @a-santamaria firstly and then reviewed by the Azure CLI team. Please note that CLI will have a code freeze for this release train tomorrow. If you want to catch this release train, please resolve these comments and have it approved as soon as possible, otherwise it has be be postponed to next sprint.

[zhoxing-ms]

@a-santamaria Could you please review this PR again?

[yanzhudd]

Please note that we will freeze CLI code on 07/02/2024 10:00 UTC for the upcoming release. If you want to catch the release train, please resolve CI issues and the comments as soon as possible, otherwise we have to postpone this PR to the next sprint (08-06).

[zhoxing-ms]

@mwesigwaguma @a-santamaria Are there any updates?

[zhoxing-ms]

@mwesigwaguma @a-santamaria Are there any updates?

[mwesigwaguma]

This is on hold for now, I will close the PR for now and reopen when it's a priority

Thanks, Guma

---

From: Xing Zhou @.> Sent: Sunday, July 28, 2024 11:58 PM To: Azure/azure-cli @.> Cc: Mwesigwa Guma @.>; Mention @.> Subject: Re: [Azure/azure-cli] [Service Fabric] az sf managed-node-type node reimage: Add new parameter --update-type to specify the way the operation will be performed (PR #28656)

@mwesigwagumahttps://github.com/mwesigwaguma @a-santamariahttps://github.com/a-santamaria Are there any updates?

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-cli/pull/28656#issuecomment-2254894708, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2RH36XCWFL75TP2OEPA2Z3ZOW4WLAVCNFSM6AAAAABFNUKI76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUHA4TINZQHA. You are receiving this because you were mentioned.Message ID: @.***>