azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

[Service Fabric] update python sdk version

Open mwesigwaguma opened this issue 1 year ago • 18 comments

Also removing unsupported parameters Precision and Mode Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change [Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

mwesigwaguma avatar Jan 19 '24 02:01 mwesigwaguma

️✔️AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.11
️✔️3.9
️✔️ams
️✔️latest
️✔️3.11
️✔️3.9
️✔️apim
️✔️latest
️✔️3.11
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.11
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️aro
️✔️latest
️✔️3.11
️✔️3.9
️✔️backup
️✔️latest
️✔️3.11
️✔️3.9
️✔️batch
️✔️latest
️✔️3.11
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.11
️✔️3.9
️✔️billing
️✔️latest
️✔️3.11
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.11
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.11
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.11
️✔️3.9
️✔️config
️✔️latest
️✔️3.11
️✔️3.9
️✔️configure
️✔️latest
️✔️3.11
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.11
️✔️3.9
️✔️container
️✔️latest
️✔️3.11
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.11
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.11
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️dla
️✔️latest
️✔️3.11
️✔️3.9
️✔️dls
️✔️latest
️✔️3.11
️✔️3.9
️✔️dms
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.11
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.11
️✔️3.9
️✔️find
️✔️latest
️✔️3.11
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.11
️✔️3.9
️✔️identity
️✔️latest
️✔️3.11
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️kusto
️✔️latest
️✔️3.11
️✔️3.9
️✔️lab
️✔️latest
️✔️3.11
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️maps
️✔️latest
️✔️3.11
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.11
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.11
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.11
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.11
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.11
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.11
️✔️3.9
️✔️profile
️✔️latest
️✔️3.11
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.11
️✔️3.9
️✔️redis
️✔️latest
️✔️3.11
️✔️3.9
️✔️relay
️✔️latest
️✔️3.11
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️role
️✔️latest
️✔️3.11
️✔️3.9
️✔️search
️✔️latest
️✔️3.11
️✔️3.9
️✔️security
️✔️latest
️✔️3.11
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.11
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.11
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.11
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.11
️✔️3.9
️✔️sql
️✔️latest
️✔️3.11
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.11
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.11
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️util
️✔️latest
️✔️3.11
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9

️✔️AzureCLI-BreakingChangeTest
️✔️Non Breaking Changes

Service Fabric

yonzhan avatar Jan 19 '24 02:01 yonzhan

@mwesigwaguma Could you please resolve these CI issues?

zhoxing-ms avatar Jan 29 '24 09:01 zhoxing-ms

@mwesigwaguma Could you please resolve these CI issues?

I am seeing this error where after the test runs and passes in live mode but in playback they fail. It seems to be a the testframework issue

except CannotOverwriteExistingCassetteException as ex:

      raise AssertionError(ex)

E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/servicefabric/tests/latest/recordings/test_update_settings_and_reliability.yaml') in your current record mode ('once'). E No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.KeyVault/vaults/clitestrg000001?api-version=2023-02-01>) was found. E Found 3 similar requests with 1 different matcher(s) :

mwesigwaguma avatar Jan 30 '24 04:01 mwesigwaguma

Hi,

I am seeing this error https://dev.azure.com/azclitools/public/_build/results?buildId=123946&view=logs&jobId=8b87d530-5472-5986-1c88-cfbbd7928469&j=8b87d530-5472-5986-1c88-cfbbd7928469&t=11cc7245-08a2-5894-29fb-f5b6001226e6 where after the test runs and passes in live mode but in playback they fail. It seems to be a the testframework issue

except CannotOverwriteExistingCassetteException as ex:

  raise AssertionError(ex)

E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/servicefabric/tests/latest/recordings/test_update_settings_and_reliability.yaml') in your current record mode ('once').

E No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.KeyVault/vaults/clitestrg000001?api-version=2023-02-01>https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.KeyVault/vaults/clitestrg000001?api-version=2023-02-01%3E) was found.

E Found 3 similar requests with 1 different matcher(s) :


From: Xing Zhou @.> Sent: Monday, January 29, 2024 4:43 AM To: Azure/azure-cli @.> Cc: Mwesigwa Guma @.>; Mention @.> Subject: Re: [Azure/azure-cli] [Service Fabric] update python sdk version (PR #28218)

@mwesigwagumahttps://github.com/mwesigwaguma Could you please resolve these CI issues?

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-cli/pull/28218#issuecomment-1914318681, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2RH36VKJ45CUIIHEUFHWL3YQ5VMNAVCNFSM6AAAAABCBIRPBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGMYTQNRYGE. You are receiving this because you were mentioned.Message ID: @.***>

mwesigwaguma avatar Jan 31 '24 03:01 mwesigwaguma

Please fix conflicting files.

yonzhan avatar Feb 19 '24 23:02 yonzhan

Please fix conflicting files.

updated

mwesigwaguma avatar Feb 20 '24 21:02 mwesigwaguma

Please fix CI issues.

yonzhan avatar Feb 21 '24 00:02 yonzhan

@mwesigwaguma Any update?

zhoxing-ms avatar Feb 26 '24 09:02 zhoxing-ms

Please note that we'll have a code freeze at 02/27/2024 10:00 UTC. Please address all the comments by that time, otherwise it has to be postponed to next sprint (next release train: 04-02).

yanzhudd avatar Feb 27 '24 06:02 yanzhudd

/azp run

jsntcy avatar Mar 01 '24 08:03 jsntcy

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Mar 01 '24 08:03 azure-pipelines[bot]

@evelyn-ys, do you know why check failed for key vault requests?

jsntcy avatar Mar 01 '24 09:03 jsntcy

@Yishi @.***> Can you please take a look at this issue : Azure/azure-cli: Azure Command-Line Interface (github.com)https://github.com/Azure/azure-cli/issues/28283 This is blocking a lot of other items including bugs that are affecting customers.

Thanks, Guma


From: Yu Chen @.> Sent: Friday, March 1, 2024 4:45 AM To: Azure/azure-cli @.> Cc: Mwesigwa Guma @.>; Mention @.> Subject: Re: [Azure/azure-cli] [Service Fabric] update python sdk version (PR #28218)

@evelyn-yshttps://github.com/evelyn-ys, do you know why errors happen to key vault requests?

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-cli/pull/28218#issuecomment-1972855944, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2RH36SQ4RRZLAG4K6766CDYWBE4PAVCNFSM6AAAAABCBIRPBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZSHA2TKOJUGQ. You are receiving this because you were mentioned.Message ID: @.***>

mwesigwaguma avatar Mar 04 '24 14:03 mwesigwaguma

Please sync with latest dev branch and run azdev setup -c again before re-recording tests

evelyn-ys avatar Mar 05 '24 02:03 evelyn-ys

@mwesigwaguma Could you please resolve these conflicts?

zhoxing-ms avatar Mar 26 '24 08:03 zhoxing-ms

@mwesigwaguma Could you please resolve these conflicts?

@mwesigwaguma Any update?

zhoxing-ms avatar Apr 22 '24 13:04 zhoxing-ms