azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

{NetAppFiles} Feature netapp add 2023 05 01

Open audunn opened this issue 1 year ago • 25 comments

Related command

az netappfiles

Description Adding support for Azure NetApp Files api-version 2023-05-01.
Note this migrates the netappfiles module to code generation with customization for backwards compatibility.

Testing Guide

History Notes

[NetAppFiles] BREAKING CHANGE: az netappfiles: All delete commands not requre confirmation as per Azure CLI convention [NetAppFiles] az netappfiles check-file-path-availability: Add new command to check if a file path is available [NetAppFiles] az netappfiles check-name-availability: Add new command to check if a resource name is available [NetAppFiles] az netappfiles check-quota-availability: Add new command to check if a quota is available [NetAppFiles] az netappfiles query-network-sibling-set: Add new command to describe a network sibling set [NetAppFiles] az netappfiles update-network-sibling-set: Add new command to Update the network features of a network sibling set [NetAppFiles] az netappfiles quota-limit: Add new command group to mange quota limits [NetAppFiles] az netappfiles volume populate-availability-zone: Add new command to populate availability zone information for a volume [NetAppFiles] az netappfiles volume replication re-initialize: Add new command to Re-establish a previously deleted replication between 2 volumes that have a common ad-hoc or policy-based snapshots


This checklist is used to make sure that common guidelines for a pull request are followed.

audunn avatar Nov 30 '23 16:11 audunn

️✔️AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.11
️✔️3.9
️✔️ams
️✔️latest
️✔️3.11
️✔️3.9
️✔️apim
️✔️latest
️✔️3.11
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.11
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️aro
️✔️latest
️✔️3.11
️✔️3.9
️✔️backup
️✔️latest
️✔️3.11
️✔️3.9
️✔️batch
️✔️latest
️✔️3.11
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.11
️✔️3.9
️✔️billing
️✔️latest
️✔️3.11
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.11
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.11
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.11
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️config
️✔️latest
️✔️3.11
️✔️3.9
️✔️configure
️✔️latest
️✔️3.11
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.11
️✔️3.9
️✔️container
️✔️latest
️✔️3.11
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.11
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.11
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️dla
️✔️latest
️✔️3.11
️✔️3.9
️✔️dls
️✔️latest
️✔️3.11
️✔️3.9
️✔️dms
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.11
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.11
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.11
️✔️3.9
️✔️find
️✔️latest
️✔️3.11
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.11
️✔️3.9
️✔️identity
️✔️latest
️✔️3.11
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️kusto
️✔️latest
️✔️3.11
️✔️3.9
️✔️lab
️✔️latest
️✔️3.11
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.11
️✔️3.9
️✔️maps
️✔️latest
️✔️3.11
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.11
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.11
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.11
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.11
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.11
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.11
️✔️3.9
️✔️profile
️✔️latest
️✔️3.11
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.11
️✔️3.9
️✔️redis
️✔️latest
️✔️3.11
️✔️3.9
️✔️relay
️✔️latest
️✔️3.11
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️role
️✔️latest
️✔️3.11
️✔️3.9
️✔️search
️✔️latest
️✔️3.11
️✔️3.9
️✔️security
️✔️latest
️✔️3.11
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.11
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.11
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.11
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.11
️✔️3.9
️✔️sql
️✔️latest
️✔️3.11
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.11
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.11
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9
️✔️util
️✔️latest
️✔️3.11
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.11
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.11
️✔️3.9
️✔️latest
️✔️3.11
️✔️3.9

❌AzureCLI-BreakingChangeTest
❌netappfiles
rule cmd_name rule_message suggest_message
1007 - ParaRemove netappfiles account ad add cmd netappfiles account ad add removed parameter group_dn please add back parameter group_dn for cmd netappfiles account ad add
1007 - ParaRemove netappfiles account ad add cmd netappfiles account ad add removed parameter group_filter please add back parameter group_filter for cmd netappfiles account ad add
1007 - ParaRemove netappfiles account ad add cmd netappfiles account ad add removed parameter user_dn please add back parameter user_dn for cmd netappfiles account ad add
1007 - ParaRemove netappfiles account ad update cmd netappfiles account ad update removed parameter encrypt_dc_conn please add back parameter encrypt_dc_conn for cmd netappfiles account ad update
1007 - ParaRemove netappfiles account ad update cmd netappfiles account ad update removed parameter group_dn please add back parameter group_dn for cmd netappfiles account ad update
1007 - ParaRemove netappfiles account ad update cmd netappfiles account ad update removed parameter group_filter please add back parameter group_filter for cmd netappfiles account ad update
1007 - ParaRemove netappfiles account ad update cmd netappfiles account ad update removed parameter user_dn please add back parameter user_dn for cmd netappfiles account ad update
1007 - ParaRemove netappfiles account backup-policy update cmd netappfiles account backup-policy update removed parameter location please add back parameter location for cmd netappfiles account backup-policy update
1007 - ParaRemove netappfiles account create cmd netappfiles account create removed parameter encryption please add back parameter encryption for cmd netappfiles account create
1010 - ParaPropUpdate netappfiles account renew-credentials cmd netappfiles account renew-credentials update parameter account_name: updated property options from ['--account-name', '--name', '-a', '-n'] to ['--account-name', '-a'] please change property options from ['--account-name', '-a'] to ['--account-name', '--name', '-a', '-n'] for parameter account_name of cmd netappfiles account renew-credentials
1007 - ParaRemove netappfiles account update cmd netappfiles account update removed parameter encryption please add back parameter encryption for cmd netappfiles account update
1007 - ParaRemove netappfiles snapshot policy update cmd netappfiles snapshot policy update removed parameter no_wait please add back parameter no_wait for cmd netappfiles snapshot policy update
1007 - ParaRemove netappfiles snapshot update cmd netappfiles snapshot update removed parameter body please add back parameter body for cmd netappfiles snapshot update
1010 - ParaPropUpdate netappfiles volume backup create cmd netappfiles volume backup create update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup create
1010 - ParaPropUpdate netappfiles volume backup delete cmd netappfiles volume backup delete update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup delete
1010 - ParaPropUpdate netappfiles volume backup list cmd netappfiles volume backup list update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup list
1006 - ParaAdd netappfiles volume backup restore-files cmd netappfiles volume backup restore-files added parameter file_list please remove parameter file_list for cmd netappfiles volume backup restore-files
1007 - ParaRemove netappfiles volume backup restore-files cmd netappfiles volume backup restore-files removed parameter destination_path please add back parameter destination_path for cmd netappfiles volume backup restore-files
1007 - ParaRemove netappfiles volume backup restore-files cmd netappfiles volume backup restore-files removed parameter file_paths please add back parameter file_paths for cmd netappfiles volume backup restore-files
1010 - ParaPropUpdate netappfiles volume backup restore-files cmd netappfiles volume backup restore-files update parameter backup_name: updated property options from ['--backup-name', '-b'] to ['--backup-name'] please change property options from ['--backup-name'] to ['--backup-name', '-b'] for parameter backup_name of cmd netappfiles volume backup restore-files
1010 - ParaPropUpdate netappfiles volume backup restore-files cmd netappfiles volume backup restore-files update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup restore-files
1010 - ParaPropUpdate netappfiles volume backup show cmd netappfiles volume backup show update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup show
1010 - ParaPropUpdate netappfiles volume backup status cmd netappfiles volume backup status update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup status
1010 - ParaPropUpdate netappfiles volume backup update cmd netappfiles volume backup update update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup update
1010 - ParaPropUpdate netappfiles volume backup wait cmd netappfiles volume backup wait update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-n', '-v'] please change property options from ['--volume-name', '-n', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume backup wait
1010 - ParaPropUpdate netappfiles volume break-file-locks cmd netappfiles volume break-file-locks update parameter client_ip: updated property options from ['--client-ip', '-i'] to ['--client-ip'] please change property options from ['--client-ip'] to ['--client-ip', '-i'] for parameter client_ip of cmd netappfiles volume break-file-locks
1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter smb_access_based_enumeration: updated property options from ['--smb-access'] to ['--smb-access-based-enumeration', '--smb-access-enumeration'] please change property options from ['--smb-access-based-enumeration', '--smb-access-enumeration'] to ['--smb-access'] for parameter smb_access_based_enumeration of cmd netappfiles volume create
1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter smb_non_browsable: updated property options from ['--smb-browsable'] to ['--smb-non-browsable'] please change property options from ['--smb-non-browsable'] to ['--smb-browsable'] for parameter smb_non_browsable of cmd netappfiles volume create
1007 - ParaRemove netappfiles volume export-policy add cmd netappfiles volume export-policy add removed parameter kerberos5_r please add back parameter kerberos5_r for cmd netappfiles volume export-policy add
1007 - ParaRemove netappfiles volume export-policy add cmd netappfiles volume export-policy add removed parameter kerberos5_rw please add back parameter kerberos5_rw for cmd netappfiles volume export-policy add
1007 - ParaRemove netappfiles volume export-policy add cmd netappfiles volume export-policy add removed parameter kerberos5i_r please add back parameter kerberos5i_r for cmd netappfiles volume export-policy add
1007 - ParaRemove netappfiles volume export-policy add cmd netappfiles volume export-policy add removed parameter kerberos5i_rw please add back parameter kerberos5i_rw for cmd netappfiles volume export-policy add
1007 - ParaRemove netappfiles volume export-policy add cmd netappfiles volume export-policy add removed parameter kerberos5p_r please add back parameter kerberos5p_r for cmd netappfiles volume export-policy add
1007 - ParaRemove netappfiles volume export-policy add cmd netappfiles volume export-policy add removed parameter kerberos5p_rw please add back parameter kerberos5p_rw for cmd netappfiles volume export-policy add
1007 - ParaRemove netappfiles volume export-policy remove cmd netappfiles volume export-policy remove removed parameter force_string please add back parameter force_string for cmd netappfiles volume export-policy remove
1007 - ParaRemove netappfiles volume export-policy remove cmd netappfiles volume export-policy remove removed parameter properties_to_add please add back parameter properties_to_add for cmd netappfiles volume export-policy remove
1007 - ParaRemove netappfiles volume export-policy remove cmd netappfiles volume export-policy remove removed parameter properties_to_remove please add back parameter properties_to_remove for cmd netappfiles volume export-policy remove
1007 - ParaRemove netappfiles volume export-policy remove cmd netappfiles volume export-policy remove removed parameter properties_to_set please add back parameter properties_to_set for cmd netappfiles volume export-policy remove
1010 - ParaPropUpdate netappfiles volume get-groupid-list-for-ldapuser cmd netappfiles volume get-groupid-list-for-ldapuser update parameter username: updated property options from ['--username', '-u'] to ['--username'] please change property options from ['--username'] to ['--username', '-u'] for parameter username of cmd netappfiles volume get-groupid-list-for-ldapuser
1010 - ParaPropUpdate netappfiles volume quota-rule list cmd netappfiles volume quota-rule list update parameter volume_name: updated property options from ['--name', '--volume-name', '-n', '-v'] to ['--volume-name', '-v'] please change property options from ['--volume-name', '-v'] to ['--name', '--volume-name', '-n', '-v'] for parameter volume_name of cmd netappfiles volume quota-rule list
1007 - ParaRemove netappfiles volume quota-rule update cmd netappfiles volume quota-rule update removed parameter quota_target please add back parameter quota_target for cmd netappfiles volume quota-rule update
1007 - ParaRemove netappfiles volume quota-rule update cmd netappfiles volume quota-rule update removed parameter quota_type please add back parameter quota_type for cmd netappfiles volume quota-rule update
1007 - ParaRemove netappfiles volume relocate cmd netappfiles volume relocate removed parameter body please add back parameter body for cmd netappfiles volume relocate
1010 - ParaPropUpdate netappfiles volume-group create cmd netappfiles volume-group create update parameter gp_rules: updated property options from ['--global-placement-rules', '--gp-rules'] to ['--gp-rules'] please change property options from ['--gp-rules'] to ['--global-placement-rules', '--gp-rules'] for parameter gp_rules of cmd netappfiles volume-group create
1010 - ParaPropUpdate netappfiles volume-group create cmd netappfiles volume-group create update parameter subnet: updated property default from default to Default please change property default from Default to default for parameter subnet of cmd netappfiles volume-group create

NetAppFiles

yonzhan avatar Nov 30 '23 16:11 yonzhan

/azp run

audunn avatar Dec 11 '23 12:12 audunn

Commenter does not have sufficient privileges for PR 27951 in repo Azure/azure-cli

azure-pipelines[bot] avatar Dec 11 '23 13:12 azure-pipelines[bot]

@kairu-ms Not sure why piprline fails now, after reverting that change in networking.

audunn avatar Dec 11 '23 13:12 audunn

/azp run

kairu-ms avatar Dec 13 '23 04:12 kairu-ms

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Dec 13 '23 04:12 azure-pipelines[bot]

/azp help

wangzelin007 avatar Dec 13 '23 06:12 wangzelin007

Supported commands

  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

azure-pipelines[bot] avatar Dec 13 '23 06:12 azure-pipelines[bot]

/azp list

wangzelin007 avatar Dec 13 '23 06:12 wangzelin007

/azp run

audunn avatar Dec 13 '23 10:12 audunn

Commenter does not have sufficient privileges for PR 27951 in repo Azure/azure-cli

azure-pipelines[bot] avatar Dec 13 '23 10:12 azure-pipelines[bot]

/azp run Azure.azure-cli Breaking Change Test

wangzelin007 avatar Dec 13 '23 10:12 wangzelin007

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Dec 13 '23 10:12 azure-pipelines[bot]

@kairu-ms updated

audunn avatar Dec 14 '23 08:12 audunn

Please add tests for the new commands.

kairu-ms avatar Dec 14 '23 09:12 kairu-ms

BTW, your PR removed the command group az netappfiles account backup. It's a breaking change. You can do that only in the breaking change window. Do you want to postpone to breaking change release, which is around March 2024.

kairu-ms avatar Dec 14 '23 09:12 kairu-ms

BTW, your PR removed the command group az netappfiles account backup. It's a breaking change. You can do that only in the breaking change window. Do you want to postpone to breaking change release, which is around March 2024.

That is too long for this release. The issue is a bit tricky since the APIs were removed to be replaced by new APIs in a preview api-version. Those are supperted in out extension netappfiles-preview.

Is there a way to work around this by adding those commands while using the older api-version even if this version is all generated to 2023-05-01? Perhaps use the old commands and SDK?

audunn avatar Dec 14 '23 09:12 audunn

BTW, your PR removed the command group az netappfiles account backup. It's a breaking change. You can do that only in the breaking change window. Do you want to postpone to breaking change release, which is around March 2024.

@kairu-ms We added support for backup command group using older api version for backwards compatability.

audunn avatar Feb 02 '24 09:02 audunn

@kairu-ms can we move this along now ?

audunn avatar Feb 06 '24 10:02 audunn

@audunn, If you want to release the changes in this PR immediately in a new version, you need update the version and history notes as well.

jsntcy avatar Feb 08 '24 03:02 jsntcy

@audunn, If you want to release the changes in this PR immediately in a new version, you need update the version and history notes as well.

Hi @jsntcy, history notes are in the pr description, should they be somewhere else as well? Also as this is our first generated version of the main NetApp Files modules I am unsure where do we update the version?

audunn avatar Feb 08 '24 09:02 audunn

@jsntcy can we move this along?

audunn avatar Feb 26 '24 12:02 audunn

@kairu-ms @necusjz can we move this along?

audunn avatar Mar 05 '24 16:03 audunn

@audunn could you please provide the pr link in aaz repo?

necusjz avatar Mar 06 '24 02:03 necusjz

/azp run

necusjz avatar Mar 06 '24 03:03 necusjz

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Mar 06 '24 03:03 azure-pipelines[bot]

@audunn could you please provide the pr link in aaz repo?

@necusjz https://github.com/Azure/aaz/pull/424

audunn avatar Mar 06 '24 09:03 audunn