azure-cli
azure-cli copied to clipboard
[AKS] raise InvalidArgumentValueError for azure cni + pod_cidr without overlay
Related command
az aks create -n mycluster -g myrg --network-plugin azure --pod-cidr 10.244.0.0/16
- will now raise a client error and specify an error message to either use Kubenet or Azure CNI Overlay
az aks create -n mycluster -g myrg --network-plugin azure --network-plugin-mode overlay --pod-cidr 10.244.0.0/16
- will not have a warning about the pod_cidr being wiped.
Description
Remove unneeded warning message when using Azure CNI Overlay and block user from specifying pod_cidr using azure cni without overlay.
Testing Guide
Built az cli locally and tested the InvalidArgumentValueError was raised when trying to use azure cni without overlay and specifying pod_cidr. Also that the warning message did not exist when creating an azure cni overlay cluster.
History Notes
[AKS] az aks create -n mycluster -g myrg --network-plugin azure --pod-cidr 10.244.0.0/16
: will now raise a client error and specify an error message to either use Kubenet or Azure CNI Overlay
[AKS] az aks create -n mycluster -g myrg --network-plugin azure --network-plugin-mode overlay --pod-cidr 10.244.0.0/16
: will not have a warning about the pod_cidr being wiped.
This checklist is used to make sure that common guidelines for a pull request are followed.
-
[x] The PR title and description has followed the guideline in Submitting Pull Requests.
-
[x] I adhere to the Command Guidelines.
-
[x] I adhere to the Error Handling Guidelines.
AKS
@tyler-lloyd Could you please resolve these CI issues?
Please note that since we will launch the release of this sprint the day after tomorrow. If you cannot address all the comments tomorrow, we will have to postpone the release of this PR to the next sprint (03-07)
The change should and has been applied to aks-preview. Feel free to close this PR, @zhoxing-ms, thanks!