azure-cli
azure-cli copied to clipboard
[AKS] `az aks upgrade`: Show warning if the Kubernetes version isn't supplied
Related command
az aks upgrade
Description
Warn on an aks [nodepool] upgrade if k8s version is supplied it will retry upgrade to same version. User was confused when upgrade without version didn't take them to "newer version"
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
-
[x] The PR title and description has followed the guideline in Submitting Pull Requests.
-
[x] I adhere to the Command Guidelines.
-
[x] I adhere to the Error Handling Guidelines.
AKS
@paulgmiller Could you please resolve the conflicts?
Could you please refer to the document Submitting Pull Requests to refine the PR title
Please note that since we will launch the release of this sprint the day after tomorrow. If you cannot address all the comments tomorrow, we will have to postpone the release of this PR to the next sprint (02-07)
Pushed a merge
Running flake8 on modules... ERROR: /mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/custom.py:2120:1: W293 blank line contains whitespace /mnt/vss/_work/1/s/src/azure-cli/azure/cli/command_modules/acs/custom.py:2120:1: W293 blank line contains whitespace 2 W293 blank line contains whitespac
@paulgmiller Could you please resolve the code style issue today? If not, we will postpone this PR to the next sprint (02-07)
I ran out of time to fix the whitespace and honestly I'm a little confused by the line numbers 2120 in the difff and locall is "Node pool {} doesnt exist, use 'aks nodepool list' to get current node pool list".format(nodepool_name))
which is neither blank nor has trailing whitepae.
So I just went through all added blank lines and found it.
A link in to how to run pylint the same way as the build would be useful. I got hundreds of errors when I ran vanilla plint
pylint custom.py | wc -l
971
ANd none of them had blank line in them
pylint custom.py | grep "blank line"
/azp run
Commenter does not have sufficient privileges for PR 24800 in repo Azure/azure-cli
/azp run
Azure Pipelines successfully started running 2 pipeline(s).