azure-cli icon indicating copy to clipboard operation
azure-cli copied to clipboard

New Load Balancer health probe parameter

Open thisisanniefang opened this issue 2 years ago • 1 comments

Related command

az network lb probe create [--probeThreshold] az network lb probe update [--probeThreshold]

Resource Provider

Microsoft.Network/loadbalancers

Description of Feature or Work Requested

Feature request to add new optional parameter --probeThreshold to the following commands: az network lb probe create az network lb probe update

Due to a longstanding known issue regarding the property --threshold, otherwise known as numberOfProbes in ARM, and "Unhealthy threshold" in Portal, we are supporting a new property known as probeThreshold that will functionally replace the old property numberOfProbes. This is avoid a breaking change. We will eventually go through the appropriate process to deprecate --threshold, however, for the moment we would just like --probeThreshold to be added as a new parameter. The new parameter is available in API versions 2022-05-01 and above.

Minimum API Version Required

2022-05-01

Swagger PR link / SDK link

https://github.com/Azure/azure-rest-api-specs/pull/20001

Request Example

No response

Target Date

2022-10-31

Additional context

No response

thisisanniefang avatar Sep 21 '22 05:09 thisisanniefang

@necusjz for awareness

yonzhan avatar Sep 21 '22 05:09 yonzhan

@yonzhan just checking in - any ETA for when the new parameter will be ready?

thisisanniefang avatar Oct 06 '22 22:10 thisisanniefang

@thisisanniefang You can track it by the right "Milestone", it means we plan to deliver it in 11/01/2022.

necusjz avatar Oct 07 '22 08:10 necusjz

@necusjz @ZengTaoxu apologies for the delayed ask as I saw that the PR has already been merged. Is it possible to add a warning to the same commands when the property --probeThreshold is specified, as such? Happy to create a new issue if preferred.

“Please note that the parameter --probeThreshold is currently in preview and is not recommended for production workloads. For most scenarios, we recommend maintaining the default value of 1 by not specifying the value of the property.”

thisisanniefang avatar Oct 30 '22 23:10 thisisanniefang

@thisisanniefang We can only add it in the next sprint/release (around 12/06), sorry for that.

necusjz avatar Oct 31 '22 02:10 necusjz

@necusjz that's fine - can we please do so? let me know if there's any action item on us to create a new issue or otherwise

thisisanniefang avatar Oct 31 '22 18:10 thisisanniefang

@thisisanniefang It's better to summarize your 2 requirements into a new issue:

  1. https://github.com/Azure/azure-cli/pull/18136#issuecomment-1293756273
  2. https://github.com/Azure/azure-cli/issues/23957#issuecomment-1296375923

necusjz avatar Nov 01 '22 02:11 necusjz