azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Application Gateway for Containers addon commands

Open JackStromberg opened this issue 1 month ago • 22 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • az aks applicationloadbalancer enable: Enable Application Load Balancer add-on for an existing cluster.
  • az aks applicationloadbalancer disable: Disable Application Load Balancer add-on for an existing cluster.
  • az aks applicationloadbalancer update: Update Application Load Balancer add-on for an existing cluster.

General Guidelines

  • [yes] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [yes] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [yes] My extension version conforms to the Extension version schema

JackStromberg avatar Nov 04 '25 08:11 JackStromberg

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd aks applicationloadbalancer sub group aks applicationloadbalancer added
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_application_load_balancer
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_application_load_balancer
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_application_load_balancer

Hi @JackStromberg, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Nov 04 '25 08:11 github-actions[bot]

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Nov 04 '25 08:11 yonzhan

Hi @JackStromberg

Release Suggestions

Module: aks-preview

  • Update VERSION to 19.0.0b18 in src/aks-preview/setup.py

Notes

github-actions[bot] avatar Nov 04 '25 08:11 github-actions[bot]

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] avatar Nov 12 '25 16:11 github-actions[bot]

/azp run

FumingZhang avatar Nov 12 '25 23:11 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Nov 12 '25 23:11 azure-pipelines[bot]

/azp run

FumingZhang avatar Nov 13 '25 06:11 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Nov 13 '25 06:11 azure-pipelines[bot]

CI failed with error

      raise HttpResponseError(response=response, model=error, error_format=ARMErrorFormat)

E azure.core.exceptions.HttpResponseError: (PreviewFeatureNotRegistered) Preview feature Microsoft.ContainerService/ApplicationLoadBalancerPreview not registered. E Code: PreviewFeatureNotRegistered E Message: Preview feature Microsoft.ContainerService/ApplicationLoadBalancerPreview not registered.

https://dev.azure.com/azclitools/public/public%20Team/_build/results?buildId=282646&view=logs&j=ff866e8d-4875-52ff-9fd3-f181f728432c&t=64f04c5b-80b8-53a1-8045-e38ac626841b&l=4547

Does the feature flag verification allow bypassing with a custom features header? If it does, you can include the relevant header in your test case and rerun the live test to create a new recording file.

FumingZhang avatar Nov 13 '25 06:11 FumingZhang

Does the feature flag verification allow bypassing with a custom features header?

@FumingZhang no, registration of the feature is required.

JackStromberg avatar Nov 13 '25 20:11 JackStromberg

Okay, in that case, you can remove the case from the default test matrix at src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json and run it in live mode in a subscription where the feature is registered. This will allow you to generate a recording file that should pass the CI check.

FumingZhang avatar Nov 13 '25 23:11 FumingZhang

/azp run

FumingZhang avatar Dec 12 '25 03:12 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Dec 12 '25 03:12 azure-pipelines[bot]

/azp run

FumingZhang avatar Dec 14 '25 23:12 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Dec 14 '25 23:12 azure-pipelines[bot]

Please fix failed CI checks, you'll need to update the recording file as the code uses a new API version 2025-10-02-preview instead of 2025-09-02-preview now

except CannotOverwriteExistingCassetteException as ex:

      raise AssertionError(ex)

E AssertionError: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_applicationloadbalancer_enable_disable.yaml') in your current record mode ('once'). E No match for the request (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000001?api-version=2025-10-02-preview>) was found. E Found 2 similar requests with 1 different matcher(s) : E
E 1 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000001?api-version=2025-09-02-preview>)..) E Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path'] E Matchers failed : E _custom_request_query_matcher - assertion failure : E None E
E 2 - (<Request (PUT) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest000001/providers/Microsoft.ContainerService/managedClusters/cliakstest000001?api-version=2025-09-02-preview>)..) E Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path'] E Matchers failed : E _custom_request_query_matcher - assertion failure : E None

FumingZhang avatar Dec 15 '25 00:12 FumingZhang

/azp run

JackStromberg avatar Dec 15 '25 19:12 JackStromberg

Commenter does not have sufficient privileges for PR 9387 in repo Azure/azure-cli-extensions

azure-pipelines[bot] avatar Dec 15 '25 19:12 azure-pipelines[bot]

/azp run

FumingZhang avatar Dec 15 '25 22:12 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Dec 15 '25 22:12 azure-pipelines[bot]

/azp run

yanzhudd avatar Dec 19 '25 03:12 yanzhudd

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Dec 19 '25 03:12 azure-pipelines[bot]

/azp run

FumingZhang avatar Dec 19 '25 03:12 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Dec 19 '25 03:12 azure-pipelines[bot]