azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

{containerapp} Fix test_containerapp_create_with_yaml test

Open Tratcher opened this issue 2 months ago • 8 comments

The traffic section wasn't getting set because the container was crashing and never transitioning to a ready state. I replaced the container image and added a retry loop while waiting for the revision to come up.

"Container 'nginx' was terminated with exit code '1' and reason 'ContainerCreateFailure'. Status(StatusCode="Unknown", Detail="failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "npm": executable file not found in $PATH: unknown")"

Tratcher avatar Oct 28 '25 21:10 Tratcher

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @Tratcher, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Oct 28 '25 21:10 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Oct 28 '25 21:10 github-actions[bot]

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] avatar Oct 28 '25 21:10 github-actions[bot]

github-actions[bot] avatar Oct 28 '25 21:10 github-actions[bot]

The Ci failed with 2 reason: 1.

- FAIL - HIGH severity: expired_parameter
    Parameter: containerapp env premium-ingress add, `max_replicas` - Deprecated parameter is expired and should be removed.
    Parameter: containerapp env premium-ingress add, `min_replicas` - Deprecated parameter is expired and should be removed.
    Parameter: containerapp env premium-ingress update, `max_replicas` - Deprecated parameter is expired and should be removed.
    Parameter: containerapp env premium-ingress update, `min_replicas` - Deprecated parameter is expired and should be removed.
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_azurefile.py::ContainerAppMountAzureFileTest::test_container_app_mount_azurefile_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_connected_env_scenario.py::ContainerappPreviewScenarioTest::test_containerapp_preview_connected_env_storage
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py::ContainerappEnvLocationNotInStageScenarioTest::test_containerapp_env_logs_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py::ContainerAppMountNfsAzureFileTest::test_container_app_mount_nfsazurefile_e2e
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerappjob_with_yaml.py::ContainerAppJobsExecutionsLocationNotInStageTest::test_containerappjob_create_with_yaml

Greedygre avatar Oct 29 '25 03:10 Greedygre

The deprecated values will be removed by https://github.com/Azure/azure-cli-extensions/pull/9265.

The e2e test failures are due to an update azure-cli version, not this PR.

Tratcher avatar Oct 29 '25 04:10 Tratcher