Fix deprecation message for blueprints.
This is just a string change to make the deprecation message clearer. Conversation was had over email with cli team.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
- [x] Have you run
azdev style <YOUR_EXT>locally? (pip install azdevrequired) - [x] Have you run
python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required) - [x ] My extension version conforms to the Extension version schema
For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes
Hi @dantedallag, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.
Thank you for your contribution! We will review the pull request and get back to you soon.
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.
Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:
pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
CodeGen Tools Feedback Collection
Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey
Hi @dantedallag
Release Suggestions
Module: blueprint
- Please log updates into to
src/blueprint/HISTORY.rst - Update
VERSIONto1.0.0b2insrc/blueprint/setup.py
Notes
- For more info about extension versioning, please refer to Extension version schema
@kairu-ms Could I get a review on this?
Last time we changed this we got help from the CLI team on the test cases and hoping we can get the same assistance here. It's just a string change, so I'm not sure why test cases would be failing.
The recording files are Out of date. Please fix them
@kairu-ms This is a correction to the change in this PR: https://github.com/Azure/azure-cli-extensions/pull/8419/files#diff-8e899430298199ff1219eb416f2599dc9d2bc20e16eae820c506329e148139f3. I attempted to run these tests live again, but ran into similar errors that I did with the last PR. Since this is only a deprecation message and there are no functional changes, live tests should not be affected, correct? Could you help consult with your team what was done in the last PR to get this passing?
Also: Has the deprecation syntax changed since I made this PR? I saw that it may have.