azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[Containerapp] `az containerapp sessionpool create`: Add `GpuBase` container type

Open ShichaoQiu opened this issue 3 months ago • 11 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

ShichaoQiu avatar Sep 28 '25 05:09 ShichaoQiu

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1010 - ParaPropUpdate containerapp sessionpool create cmd containerapp sessionpool create update parameter container_type: updated property choices from ['CustomContainer', 'NodeLTS', 'PythonLTS'] to ['CustomContainer', 'GpuBase', 'NodeLTS', 'PythonLTS']

Hi @ShichaoQiu, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Sep 28 '25 05:09 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Sep 28 '25 05:09 github-actions[bot]

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] avatar Sep 28 '25 05:09 github-actions[bot]

Hi @ShichaoQiu

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b5 in src/containerapp/setup.py

Notes

github-actions[bot] avatar Sep 28 '25 05:09 github-actions[bot]

Please fix CI issues

yonzhan avatar Sep 28 '25 07:09 yonzhan

The CI failed due to Microsoft.Storage upgrade api-version in azure-cli, I will create a PR to update this recording files.

Greedygre avatar Sep 28 '25 13:09 Greedygre

The CI failed due to Microsoft.Storage upgrade api-version in azure-cli, I will create a PR to update this recording files.

https://github.com/Azure/azure-cli-extensions/pull/9281

Greedygre avatar Oct 09 '25 08:10 Greedygre

Hi @ShichaoQiu You can rebase the main branch. The integration Test has been merged.

Update: Due to api-version updated with PR: https://github.com/Azure/azure-cli/pull/32179/ Need to rerun all tests in extension for containerapp. I am working on this.

Greedygre avatar Oct 10 '25 03:10 Greedygre

Update: The PR for update recording files updated. Please sync the main branch.

Greedygre avatar Oct 14 '25 05:10 Greedygre