azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Create a nodepool with ManagedSystem mode

Open hao1939 opened this issue 6 months ago • 12 comments

ManagedSystem Pool Support. This feature introduces comprehensive support for ManagedSystem node pools, enabling users to:

  1. Create Kubernetes clusters with a fully managed system node pool.
  2. Provision new node pools in ManagedSystem mode.
  3. Transition existing ManagedSystem pools back to normal system pools.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g MyResourceGroup -n MyManagedCluster --managed-system-pool

General Guidelines

  • [ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

hao1939 avatar Jun 23 '25 05:06 hao1939

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_managed_system_pool
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter mode: updated property choices from ['Gateway', 'System', 'User'] to ['Gateway', 'ManagedSystem', 'System', 'User']
⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool update update parameter mode: updated property choices from ['Gateway', 'System', 'User'] to ['Gateway', 'ManagedSystem', 'System', 'User']

Hi @hao1939, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Jun 23 '25 05:06 github-actions[bot]

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Jun 23 '25 05:06 yonzhan

Hi @hao1939

Release Suggestions

Module: aks-preview

  • Update VERSION to 18.0.0b19 in src/aks-preview/setup.py

Notes

github-actions[bot] avatar Jun 23 '25 05:06 github-actions[bot]

/azp run

FumingZhang avatar Jun 23 '25 07:06 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jun 23 '25 07:06 azure-pipelines[bot]

seems the live test failed with error

  if self.agentpool_decorator_mode == AgentPoolDecoratorMode.MANAGED_CLUSTER:
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

E AttributeError: 'AKSPreviewAgentPoolAddDecoratorCommonTestCase' object has no attribute 'agentpool_decorator_mode'

FumingZhang avatar Jun 23 '25 07:06 FumingZhang

/azp run

FumingZhang avatar Jun 24 '25 04:06 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jun 24 '25 04:06 azure-pipelines[bot]

/azp run

FumingZhang avatar Jun 25 '25 04:06 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jun 25 '25 04:06 azure-pipelines[bot]

/azp run

FumingZhang avatar Jul 03 '25 01:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 03 '25 01:07 azure-pipelines[bot]

/azp run

FumingZhang avatar Jul 07 '25 07:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 07 '25 07:07 azure-pipelines[bot]

/azp run

FumingZhang avatar Jul 09 '25 00:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '25 00:07 azure-pipelines[bot]

/azp run

hao1939 avatar Jul 09 '25 02:07 hao1939

Commenter does not have sufficient privileges for PR 8891 in repo Azure/azure-cli-extensions

azure-pipelines[bot] avatar Jul 09 '25 02:07 azure-pipelines[bot]

/azp run

FumingZhang avatar Jul 09 '25 03:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '25 03:07 azure-pipelines[bot]

/azp run

FumingZhang avatar Jul 09 '25 05:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '25 05:07 azure-pipelines[bot]

/azp run

FumingZhang avatar Jul 09 '25 23:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 09 '25 23:07 azure-pipelines[bot]

Live test passed!

  • test_aks_create_normal_cluster_then_add_managed_system_pool
  • test_aks_create_with_managed_system_pool_multiple_fails
  • test_aks_update_with_managed_system_pool

FumingZhang avatar Jul 10 '25 05:07 FumingZhang

Please add some changelog in the HISTORY.rst file. If you want to release a new version, please update the setup.py file as well.

yanzhudd avatar Jul 14 '25 01:07 yanzhudd

Please add some changelog in the HISTORY.rst file. If you want to release a new version, please update the setup.py file as well.

hao1939 avatar Jul 14 '25 05:07 hao1939

Thanks @yanzhudd! Added, could you help to take a second look?

hao1939 avatar Jul 14 '25 05:07 hao1939