Create a nodepool with ManagedSystem mode
ManagedSystem Pool Support. This feature introduces comprehensive support for ManagedSystem node pools, enabling users to:
- Create Kubernetes clusters with a fully managed system node pool.
- Provision new node pools in ManagedSystem mode.
- Transition existing ManagedSystem pools back to normal system pools.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create -g MyResourceGroup -n MyManagedCluster --managed-system-pool
General Guidelines
- [ ] Have you run
azdev style <YOUR_EXT>locally? (pip install azdevrequired) - [ ] Have you run
python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required) - [ ] My extension version conforms to the Extension version schema
For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message ❌ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool addupdate parameterspot_max_price: updated propertydefaultfromnantonanplease change property defaultfromnantonanfor parameterspot_max_priceof cmdaks nodepool add⚠️ 1006 - ParaAdd aks create cmd aks createadded parameterenable_managed_system_pool⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool addupdate parametermode: updated propertychoicesfrom['Gateway', 'System', 'User']to['Gateway', 'ManagedSystem', 'System', 'User']⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool updateupdate parametermode: updated propertychoicesfrom['Gateway', 'System', 'User']to['Gateway', 'ManagedSystem', 'System', 'User']
Hi @hao1939, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.
Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:
pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
Thank you for your contribution! We will review the pull request and get back to you soon.
Hi @hao1939
Release Suggestions
Module: aks-preview
- Update
VERSIONto18.0.0b19insrc/aks-preview/setup.py
Notes
- For more info about extension versioning, please refer to Extension version schema
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
seems the live test failed with error
if self.agentpool_decorator_mode == AgentPoolDecoratorMode.MANAGED_CLUSTER:^^^^^^^^^^^^^^^^^^^^^^^^^^^^^E AttributeError: 'AKSPreviewAgentPoolAddDecoratorCommonTestCase' object has no attribute 'agentpool_decorator_mode'
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
/azp run
Commenter does not have sufficient privileges for PR 8891 in repo Azure/azure-cli-extensions
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
Live test passed!
- test_aks_create_normal_cluster_then_add_managed_system_pool
- test_aks_create_with_managed_system_pool_multiple_fails
- test_aks_update_with_managed_system_pool
Please add some changelog in the HISTORY.rst file. If you want to release a new version, please update the setup.py file as well.
Please add some changelog in the HISTORY.rst file. If you want to release a new version, please update the setup.py file as well.
Thanks @yanzhudd! Added, could you help to take a second look?