azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[k8s-extension] Remove code related to EntraWorkloadIAM

Open AntonioND opened this issue 6 months ago • 6 comments
trafficstars

This code is no longer required. Its original purpose was to generate a join token without user input to simplify the setup of the extension.

This PR is the same as https://github.com/AzureArcForKubernetes/azure-cli-extensions/pull/287 but applied to this repository.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az k8s-extension create

General Guidelines

  • [X] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [X] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

AntonioND avatar May 22 '25 10:05 AntonioND

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @AntonioND, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar May 22 '25 10:05 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar May 22 '25 10:05 github-actions[bot]

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] avatar May 22 '25 10:05 github-actions[bot]

github-actions[bot] avatar May 22 '25 10:05 github-actions[bot]

Hi! Can I get a review here? The Arc extension that required this code was cancelled months ago. This is dead code and it should be removed.

AntonioND avatar Jul 28 '25 10:07 AntonioND

/azp run

zhoxing-ms avatar Jul 29 '25 03:07 zhoxing-ms

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 29 '25 03:07 azure-pipelines[bot]

It looks like all the style issues in the pipelines are in code that hasn't been touched by this PR.

AntonioND avatar Jul 29 '25 09:07 AntonioND

[Release] Update index.json for extension [ k8s-extension-1.6.6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131982681&view=results

azclibot avatar Jul 29 '25 09:07 azclibot