azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[AKS] chore: remove --skip-gpu-driver-install

Open lilypan26 opened this issue 7 months ago • 5 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

--skip-gpu-driver-install, --gpu-driver None/Install

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

lilypan26 avatar May 21 '25 18:05 lilypan26

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks nodepool add cmd aks nodepool add removed parameter skip_gpu_driver_install please add back parameter skip_gpu_driver_install for cmd aks nodepool add
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add

Hi @lilypan26, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar May 21 '25 18:05 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar May 21 '25 18:05 github-actions[bot]

Hi @lilypan26

Release Suggestions

Module: aks-preview

  • Update VERSION to 18.0.0b3 in src/aks-preview/setup.py

Notes

github-actions[bot] avatar May 21 '25 18:05 github-actions[bot]