azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Parameterize SSH extension for the air gapped clouds

Open mcnealm13 opened this issue 9 months ago • 6 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

mcnealm13 avatar Mar 20 '25 15:03 mcnealm13

Validation for Breaking Change Starting...

Thanks for your contribution!

Hi @mcnealm13, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Mar 20 '25 15:03 yonzhan

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Mar 20 '25 15:03 github-actions[bot]

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

github-actions[bot] avatar Mar 20 '25 15:03 github-actions[bot]

Hi @mcnealm13

Release Suggestions

Module: ssh

  • Please log updates into to src/ssh/HISTORY.rst
  • Update VERSION to 2.0.7 in src/ssh/setup.py

Notes

github-actions[bot] avatar Mar 20 '25 16:03 github-actions[bot]

@vthiebaut10 can you review again ? CC @anwarnuma

Alex-AZPS avatar Jul 07 '25 22:07 Alex-AZPS

Previously the SSH auth scope is hard-coded in Azure PowerShell, and later it leverages "Environment" to store the scope to support new sovereign clouds:

  • https://github.com/Azure/azure-powershell-common/pull/447
  • https://github.com/Azure/azure-powershell/pull/27878

This approach makes sense to me. We can add --ssh-auth-scope when registering a cloud, such as

az cloud register --ssh-auth-scope "https://pas.windows.net/CheckMyAccess/Linux/.default

jiasli avatar Jul 31 '25 09:07 jiasli