azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Breaking change message for associate-public-ip

Open Sandido opened this issue 9 months ago • 9 comments


This parameter has been misleading for a while, will just become a flag parameter now instead of incorrectly using the False boolean as a true value and creating a public ip anyway.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az vm repair create

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Sandido avatar Mar 07 '25 18:03 Sandido

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @Sandido, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

github-actions[bot] avatar Mar 07 '25 18:03 github-actions[bot]

github-actions[bot] avatar Mar 07 '25 18:03 github-actions[bot]

Compute

yonzhan avatar Mar 07 '25 23:03 yonzhan

/azp run

zhoxing-ms avatar Mar 10 '25 06:03 zhoxing-ms

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Mar 10 '25 06:03 azure-pipelines[bot]

Hi @Sandido , we are exploring a new way to announce breaking changes. And in this breaking change window we plan to extend the scope from core cli to extensions. If we use the new announcement method, we will have a scheduled pipeline to collect these breaking changes in a centralized document(https://learn.microsoft.com/en-us/cli/azure/upcoming-breaking-changes). Could you take some time to try the new way to announce breaking changes? https://github.com/Azure/azure-cli/blob/dev/doc/how_to_introduce_breaking_changes.md

Since the pipeline part is not ready yet (though it will be ready this month), you could try our new method (and I will use it as an example to ensure it displays correctly in the document), or you can just ping Xing and let him review and merge the original PR. Please note that we are exploring ways to manage breaking changes better, so in the near future, the new way to announce breaking changes will be required. cc @zhoxing-ms

ReaNAiveD avatar Mar 14 '25 06:03 ReaNAiveD

@Sandido Does Azure PowerShell also have this breaking change?

Alex-AZPS avatar Apr 29 '25 23:04 Alex-AZPS