azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Fix public IP turn off option

Open Sandido opened this issue 1 year ago • 8 comments


Taking over this PR: https://github.com/Azure/azure-cli-extensions/pull/7866

This PR fixes a longstanding bug where the option to not create a public IP was broken and would just create a public IP with the name False.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Sandido avatar Oct 17 '24 14:10 Sandido

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @Sandido, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Oct 17 '24 14:10 yonzhan

Hi @Sandido

Release Suggestions

Module: vm-repair

  • Update VERSION to 1.1.2 in src/vm-repair/setup.py

Notes

github-actions[bot] avatar Oct 17 '24 14:10 github-actions[bot]

please resolve code conflicts

yanzhudd avatar Oct 21 '24 06:10 yanzhudd

@yanzhudd please re-review!

Sandido avatar Oct 23 '24 14:10 Sandido

This PR is still in draft status

yonzhan avatar Oct 23 '24 23:10 yonzhan

@yonzhan , was temporarily in draft, ready for re-review!

Sandido avatar Oct 24 '24 01:10 Sandido

It looks good to me. But please note that Azure CLI is only responsible for code style and specification but not business logic, so it is better to involve service team to review it as well.

yanzhudd avatar Oct 24 '24 06:10 yanzhudd