Fix public IP turn off option
Taking over this PR: https://github.com/Azure/azure-cli-extensions/pull/7866
This PR fixes a longstanding bug where the option to not create a public IP was broken and would just create a public IP with the name False.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
- [x] Have you run
azdev style <YOUR_EXT>locally? (pip install azdevrequired) - [x] Have you run
python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required) - [x] My extension version conforms to the Extension version schema
For new extensions:
- [x] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes
Hi @Sandido, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.
Thank you for your contribution! We will review the pull request and get back to you soon.
Hi @Sandido
Release Suggestions
Module: vm-repair
- Update
VERSIONto1.1.2insrc/vm-repair/setup.py
Notes
- For more info about extension versioning, please refer to Extension version schema
please resolve code conflicts
@yanzhudd please re-review!
This PR is still in draft status
@yonzhan , was temporarily in draft, ready for re-review!
It looks good to me. But please note that Azure CLI is only responsible for code style and specification but not business logic, so it is better to involve service team to review it as well.