azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Changing default windows image from the old 2016 to the 2022 image

Open Sandido opened this issue 1 year ago • 7 comments


This is technically a breaking change, with the messaging being sent here: Default windows image change breaking change warning, Win2016 to Win2022 by Sandido · Pull Request #8045 · Azure/azure-cli-extensions (github.com)

Update: changing the image to 2022 smalldisk instead to reduce the breaking change impact and due to a known disk id conflict issue with identical images.

This change prevents the old 2016 image from being used by default, rather to a newer method that first tries to use the source VM image, and if that cannot be found it uses the 2022 image.
This PR should be released in time for the November Ignite breaking change release.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Sandido avatar Oct 01 '24 18:10 Sandido

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @Sandido, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Hi @Sandido, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Oct 01 '24 18:10 yonzhan

github-actions[bot] avatar Oct 01 '24 18:10 github-actions[bot]

This PR is in draft status

yonzhan avatar Oct 15 '24 23:10 yonzhan

Using Azure CLI to deploy a 2019-Datacenter-GS image does not work, it returns an error of OS Provision Timed out. Maybe it does work if timeout is modified, but I am unable to verify that.

Sandido avatar Oct 16 '24 20:10 Sandido

Please fix conflicting files

yonzhan avatar Oct 26 '24 00:10 yonzhan

@yonzhan PR is ready

Sandido avatar Oct 31 '24 16:10 Sandido

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/release/_build/results?buildId=202634&view=results

azclibot avatar Nov 01 '24 02:11 azclibot